PARQUET-1387: Nanosecond precision time and timestamp - parquet-format #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
May want to add a comment to indicate the representable range for INT64 nanosecond timestamps so users are aware of the limitations (this has caused occasional issues in pandas because we are nanosecond-native) |
Contributor
Author
|
Thanks @wesm for your review! I noticed that I forgot to mention nanosecond precision from the logical types documentation, added the representable range there. Could you please verify that my calculations are correct? |
gszadovszky
approved these changes
Aug 27, 2018
Contributor
gszadovszky
left a comment
gszadovszky
left a comment
There was a problem hiding this comment.
LGTM.
I'll commit this tomorrow if no other comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce new nanosecond precision in TimeUnit