Skip to content

GH-3205: Make HadoopPositionOutputStream.close() safe to call even if closed #3206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wgtmac merged 2 commits into from
May 10, 2025
Merged

GH-3205: Make HadoopPositionOutputStream.close() safe to call even if closed #3206

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
433075e
Make HadoopPositionOutputStream.close() safe to call even if closed
dominicso Apr 29, 2025
4ed957b
use AtomicBoolean for close
dominicso May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/HadoopPositionOutputStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,13 @@
package org.apache.parquet.hadoop.util;

import java.io.IOException;
import java.util.concurrent.atomic.AtomicBoolean;
import org.apache.hadoop.fs.FSDataOutputStream;
import org.apache.parquet.io.PositionOutputStream;

public class HadoopPositionOutputStream extends PositionOutputStream {
private final FSDataOutputStream wrapped;
private final AtomicBoolean closed = new AtomicBoolean(false);

HadoopPositionOutputStream(FSDataOutputStream wrapped) {
this.wrapped = wrapped;
Expand Down Expand Up @@ -61,6 +63,9 @@ public void flush() throws IOException {

@Override
public void close() throws IOException {
if (closed.getAndSet(true)) {
return;
}
try (FSDataOutputStream fdos = wrapped) {
fdos.flush();
}
Expand Down