Skip to content

PARQUET-1253: Support for new logical type representation #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gszadovszky merged 12 commits into from
May 24, 2018
Merged

PARQUET-1253: Support for new logical type representation #463

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
244bb6a
PARQUET-1253: Support for new logical type representation
nkollar Mar 28, 2018
0a66346
refactor: move conversion logic to logical type classes
nkollar Mar 29, 2018
f8e2236
better (hopefully) name for new type
nkollar Mar 29, 2018
6b4ff74
Address code review comments
nkollar Apr 4, 2018
f801605
Deprecate old constructors, address comment related to builder
nkollar Apr 18, 2018
db30adb
Address latest comments
nkollar Apr 19, 2018
047feb9
Introduce type visitors for logical types, and address code review co…
nkollar Apr 24, 2018
d11a09c
Move factory methods to the interface for each logical type subclass
nkollar Apr 24, 2018
eb432f7
Incorporate new logical type parameters into schema language
nkollar May 8, 2018
3c426d9
Address latest code review comments
nkollar May 11, 2018
77f1d52
Make LogicalTypeToken enum and getType method package private
nkollar May 14, 2018
6e1ea5d
Make typeParametersAsString package private
nkollar May 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Incorporate new logical type parameters into schema language 
This commit
* Address code review changes: replace Interval and KeyValue logical type factory methods with methods on logical
  type to indicate that they're not intended to be used publicly
* Incorporate new parameters for logical types for timestamp, time and integer
  • Loading branch information
@nkollar
nkollar committed May 8, 2018
commit eb432f7305087ec23f7cb9add793ff8ca440599d
Loading