PARQUET-1410: Refactor modules to use the new logical type API #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gszadovszky
requested changes
Aug 31, 2018
Contributor
gszadovszky
left a comment
gszadovszky
left a comment
There was a problem hiding this comment.
Reviewed till LogicalTypeAnnotation. Will continue later.
parquet-arrow/src/main/java/org/apache/parquet/arrow/schema/SchemaConverter.java
Outdated
Show resolved
Hide resolved
parquet-arrow/src/main/java/org/apache/parquet/arrow/schema/SchemaConverter.java
Outdated
Show resolved
Hide resolved
parquet-arrow/src/main/java/org/apache/parquet/arrow/schema/SchemaConverter.java
Outdated
Show resolved
Hide resolved
parquet-arrow/src/main/java/org/apache/parquet/arrow/schema/SchemaConverter.java
Outdated
Show resolved
Hide resolved
parquet-arrow/src/main/java/org/apache/parquet/arrow/schema/SchemaConverter.java
Outdated
Show resolved
Hide resolved
parquet-avro/src/main/java/org/apache/parquet/avro/AvroSchemaConverter.java
Outdated
Show resolved
Hide resolved
parquet-avro/src/main/java/org/apache/parquet/avro/AvroSchemaConverter.java
Outdated
Show resolved
Hide resolved
parquet-column/src/main/java/org/apache/parquet/schema/GroupType.java
Outdated
Show resolved
Hide resolved
parquet-column/src/main/java/org/apache/parquet/schema/LogicalTypeAnnotation.java
Outdated
Show resolved
Hide resolved
parquet-column/src/main/java/org/apache/parquet/schema/LogicalTypeAnnotation.java
Outdated
Show resolved
Hide resolved
HiveSchemaConverter in org.apache.hadoop.hive.ql.io.parquet.convert uses it
gszadovszky
requested changes
Sep 7, 2018
parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveType.java
Show resolved
Hide resolved
parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveType.java
Outdated
Show resolved
Hide resolved
parquet-column/src/main/java/org/apache/parquet/schema/GroupType.java
Outdated
Show resolved
Hide resolved
parquet-column/src/test/java/org/apache/parquet/schema/TestMessageType.java
Outdated
Show resolved
Hide resolved
parquet-pig/src/main/java/org/apache/parquet/pig/PigSchemaConverter.java
Outdated
Show resolved
Hide resolved
parquet-protobuf/src/main/java/org/apache/parquet/proto/ProtoSchemaConverter.java
Show resolved
Hide resolved
parquet-tools/src/main/java/org/apache/parquet/tools/read/SimpleRecordConverter.java
Outdated
Show resolved
Hide resolved
Rewrite Pig primitive type creation to builders
With wrapper RuntimeException the underlying checked FrontendException could be rethrown outside of the of the visitor, this way retaining backward compatibility
zivanfi
reviewed
Sep 11, 2018
parquet-column/src/main/java/org/apache/parquet/schema/LogicalTypeAnnotation.java
Show resolved
Hide resolved
zivanfi
approved these changes
Sep 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Parquet internal logic to use LogicalType API instead of ConvertedType