Skip to content

Conversation

@raulcd
Copy link
Member

@raulcd raulcd commented Jan 28, 2025

Rationale for this change

There is currently no guide on how to verify. Having a guide will encourage people to verify the release.
This guide should also be linked on the Voting thread.

What changes are included in this PR?

Added documentation about how to verify.

Are these changes tested?

I've validated all steps localy

Closes apache/parquet-java#3091

(Maybe someone with permissions can move that issue to this repo :) )

Copy link
Member

@wgtmac wgtmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Thanks @raulcd!

cc @gszadovszky @Fokko

The command will output a summary, the list of files with their licenses and any file that does not contain a valid license header.

```
java -jar apache-rat-0.16.1/apache-rat-0.16.1.jar -a -d apache-parquet-1.15.0.tar.gz -e "\w+.avsc$|\w+\-2.parquet$|.gitignore|PULL_REQUEST_TEMPLATE.md"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add the excluded files to a .rat-excludes file: https://github.com/apache/iceberg/blob/main/dev/.rat-excludes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I was having some issues integrating the .rat-excludes file with the rat-plugin on my original PR:
https://github.com/apache/parquet-java/pull/3101/files#r1876006229
We might want to do that once we update rat-plugin to use a single source for rat-excludes instead of listing exclusions on the pom.xml?

@wgtmac
Copy link
Member

wgtmac commented Feb 26, 2025

Should we merge this? Do you have any concern? @Fokko

@alamb
Copy link
Collaborator

alamb commented Nov 14, 2025

@raulcd shall we merge this PR? Looks like it has been waiting for a while and @wgtmac last asked in Feb.

If we don't hear anything by the end of the year, perhaps we should close this PR (and we can always reopen if/when we want to reconsider)

@alamb alamb changed the title Add verification guide for release Add verification guide for parquet-java release Nov 14, 2025
@raulcd
Copy link
Member Author

raulcd commented Nov 14, 2025

Thanks for the ping @alamb , totally forgot about this.
@Fokko had a valid concern. I wasn't able to fix the Java apache-rat pom configuration issue mentioned and didn't have more time for it.
We could:

  • merge as is and follow up once we update the rat-plugin
  • Update the instructions for license check and leave it as You must check licenses but not give individual steps on how to do it.
  • Someone spends some time to try and fix the rat-plugin issue.
  • Close the PR. Even though I think there are some nice improvements to the verification guide :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add documentation about how to verify the release

5 participants