Skip to content

[SPARK-43305] Add support for java 17 from spark 3.5.0 #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vakarisbk wants to merge 4 commits into from
Closed

[SPARK-43305] Add support for java 17 from spark 3.5.0 #56

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
57edd2f
Add support for java17 from Spark 3.5.0
vakarisbk Oct 13, 2023
0c81c27
fix typos
vakarisbk Oct 22, 2023
2772359
fix whitespace typo
vakarisbk Oct 22, 2023
b236385
exclude java17 tags from versions 3.3.x and 3.4.x
vakarisbk Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
exclude java17 tags from versions 3.3.x and 3.4.x
  • Loading branch information
@vakarisbk
vakarisbk committed Nov 6, 2023
commit b236385b9b413dda3c21bc0bb6608378d8a95b2e
15 changes: 11 additions & 4 deletions add-dockerfiles.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,18 @@ scala2.12-java11-python3-r-ubuntu
scala2.12-java11-python3-ubuntu
scala2.12-java11-r-ubuntu
scala2.12-java11-ubuntu
scala2.12-java17-python3-r-ubuntu
scala2.12-java17-python3-ubuntu
scala2.12-java17-r-ubuntu
scala2.12-java17-ubuntu
"

# java17 images were added in 3.5.0. We need to skip java17 for 3.3.x and 3.4.x
if ! echo $VERSION | grep -Eq "^3.3|^3.4"; then
TAGS+="
scala2.12-java17-python3-r-ubuntu
scala2.12-java17-python3-ubuntu
scala2.12-java17-r-ubuntu
scala2.12-java17-ubuntu
"
fi

for TAG in $TAGS; do
OPTS=""
if echo $TAG | grep -q "python"; then
Expand Down Expand Up @@ -66,4 +72,5 @@ for TAG in $TAGS; do
else
python3 tools/template.py $OPTS -f r-python.template > $VERSION/$TAG/Dockerfile
fi

done