Skip to content

Conversation

@Yikun
Copy link
Member

@Yikun Yikun commented Jun 21, 2024

What changes were proposed in this pull request?

Why are the changes needed?

update 4.0.0-preview1

Does this PR introduce any user-facing change?

new release

How was this patch tested?

./add-dockerfiles.sh 4.0.0-preview1 , no diff

@Yikun
Copy link
Member Author

Yikun commented Jun 21, 2024

29.02 + gpg --batch --keyserver hkps://keys.openpgp.org --recv-key 4DC9676CEF9A83E98FCA02784D6620843CD87F5A
29.03 gpg: keybox '/tmp/tmp.NsK96iEJwQ/pubring.kbx' created
30.05 gpg: key 4D6620843CD87F5A: new key but contains no user ID - skipped
30.05 gpg: Total number processed: 1
30.05 gpg:           w/o user IDs: 1
30.05 + gpg --batch --verify spark.tgz.asc spark.tgz
32.10 gpg: Signature made Tue 28 May 2024 04:39:57 PM UTC
32.10 gpg:                using RSA key 4DC9676CEF9A83E98FCA02784D6620843CD87F5A
32.10 gpg:                issuer "[email protected]"
32.10 gpg: Can't check signature: No public key
------

cc @cloud-fan maybe need to add gpg key according #54 (comment)

@Yikun Yikun changed the title Update 4.0.0-preview1 [SPARK-48664][FOLLOWUP] Update 4.0.0-preview1 Jun 21, 2024
@cloud-fan
Copy link
Contributor

@Yikun Done, not sure how soon it will be available

"4.0.0-preview1-java17",
"python3-java17"
"4.0.0-preview1-python3",
"4.0.0-preview1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we tag the "all-in-one" image with this spark version only name?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or we think it's better to exclude R support by default?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this was the first version, I might have preferred to have all-in-one to have 4.0.0-preview1
but it's been like that already so I think it's fine

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member Author

@Yikun Yikun Jun 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, 4.0.0-preview1 haven't been tagged in the published image (apache/spark) yet.

So, we can tag 4.0.0-preview1 on 4.0.0-preview1/scala2.13-java17-python3-r-ubuntu. that means the apache/spark:4.0.0-preview1/scala2.13-java17-python3-r-ubuntu will have a new alias tag 4.0.0-preview1.

@cloud-fan
Copy link
Contributor

BTW, there is no place mentioning add-dockerfiles.sh, neither the spark release process doc, nor the README of this repo. Shall we mention it somewhere and ask release managers to use it?

@Yikun
Copy link
Member Author

Yikun commented Jun 21, 2024

Done, not sure how soon it will be available

seems already work.

there is no place mentioning add-dockerfiles.sh, neither the spark release process doc, nor the README of this repo. Shall we mention it somewhere and ask release managers to use it?

Yes, we can! Now, only mentioned in spark-docker CONTRIBUTING.md

@Yikun
Copy link
Member Author

Yikun commented Jun 21, 2024

there is no place mentioning add-dockerfiles.sh, neither the spark release process doc, nor the README of this repo. Shall we mention it somewhere and ask release managers to use it?

I added the doc, maybe you could give some review from release manager view. See 7bc0c58

@Yikun Yikun marked this pull request as ready for review June 21, 2024 09:05

### Step 2. Publish apache/spark Images.

Click [Publish (Java 17 only)](https://github.com/apache/spark-docker/actions/workflows/publish-java17.yaml) (such as 4.x) or [Publish](https://github.com/apache/spark-docker/actions/workflows/publish.yml) (such as 3.x) to publish images.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is also a Publish (Java 11 only), shall we mention it?

Copy link
Member Author

@Yikun Yikun Jun 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you didn't notice the first line before "or"? java 17 already mentioned, :)

for 4.x, java 17; for 3.x, java 17 and java 11.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't mention https://github.com/apache/spark-docker/blob/master/.github/workflows/publish-java11.yml ? Or we should remove this file if it's no longer in use.

versions.json Outdated
"tags": [
"4.0.0-preview1-scala2.13-java17-python3-r-ubuntu"
"4.0.0-preview1-scala2.13-java17-python3-r-ubuntu",
"4.0.0-preview1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If other Spark versions (3.x) exclude R support by default, I think 4.0 should follow it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@Yikun Yikun closed this in b1b1019 Jun 24, 2024
@Yikun
Copy link
Member Author

Yikun commented Jun 24, 2024

Merged. @HyukjinKwon @cloud-fan Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants