-
Notifications
You must be signed in to change notification settings - Fork 52
[SPARK-48664][FOLLOWUP] Update 4.0.0-preview1 #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @cloud-fan maybe need to add gpg key according #54 (comment) |
|
@Yikun Done, not sure how soon it will be available |
| "4.0.0-preview1-java17", | ||
| "python3-java17" | ||
| "4.0.0-preview1-python3", | ||
| "4.0.0-preview1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we tag the "all-in-one" image with this spark version only name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or we think it's better to exclude R support by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm neutral on this. As I mentioned only had some short discussion on it.
cc @zhengruifeng @HyukjinKwon @gengliangwang any idea?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this was the first version, I might have preferred to have all-in-one to have 4.0.0-preview1
but it's been like that already so I think it's fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, 4.0.0-preview1 haven't been tagged in the published image (apache/spark) yet.
So, we can tag 4.0.0-preview1 on 4.0.0-preview1/scala2.13-java17-python3-r-ubuntu. that means the apache/spark:4.0.0-preview1/scala2.13-java17-python3-r-ubuntu will have a new alias tag 4.0.0-preview1.
|
BTW, there is no place mentioning |
seems already work.
Yes, we can! Now, only mentioned in spark-docker CONTRIBUTING.md |
I added the doc, maybe you could give some review from release manager view. See 7bc0c58 |
|
|
||
| ### Step 2. Publish apache/spark Images. | ||
|
|
||
| Click [Publish (Java 17 only)](https://github.com/apache/spark-docker/actions/workflows/publish-java17.yaml) (such as 4.x) or [Publish](https://github.com/apache/spark-docker/actions/workflows/publish.yml) (such as 3.x) to publish images. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is also a Publish (Java 11 only), shall we mention it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you didn't notice the first line before "or"? java 17 already mentioned, :)
for 4.x, java 17; for 3.x, java 17 and java 11.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't mention https://github.com/apache/spark-docker/blob/master/.github/workflows/publish-java11.yml ? Or we should remove this file if it's no longer in use.
versions.json
Outdated
| "tags": [ | ||
| "4.0.0-preview1-scala2.13-java17-python3-r-ubuntu" | ||
| "4.0.0-preview1-scala2.13-java17-python3-r-ubuntu", | ||
| "4.0.0-preview1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If other Spark versions (3.x) exclude R support by default, I think 4.0 should follow it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
|
Merged. @HyukjinKwon @cloud-fan Thanks! |
What changes were proposed in this pull request?
wget -nv -O KEYS https://downloads.apache.org/spark/KEYSandgpg --import KEYS;, it works but not meet the security concern from DOI.add-dockerfiles.sh 4.0.0-preview1support to address [SPARK-48664] Add Apache Spark 4.0.0-preview1 Dockerfiles #61 (comment)versions.json: consider java17 as default version, so we can remove java17 tag.Why are the changes needed?
update 4.0.0-preview1
Does this PR introduce any user-facing change?
new release
How was this patch tested?
./add-dockerfiles.sh 4.0.0-preview1 , no diff