Skip to content

Contribution guide to document actual guide for pull requests #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
khalidmammadov wants to merge 6 commits into from
Closed

Contribution guide to document actual guide for pull requests #378

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
eafd65f
Contribution guide to document actual guide for pull requests
khalidmammadov Jan 30, 2022
dc0aa61
Include compiled files as well
khalidmammadov Jan 30, 2022
719093f
Reverting sitemap changes as it was not intended
khalidmammadov Jan 30, 2022
4d8b785
Incorporating review comments
khalidmammadov Jan 31, 2022
59879b5
And the new line
khalidmammadov Jan 31, 2022
a27be46
Last place where 1s were replaced by IntellyJ
khalidmammadov Jan 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
And the new line
  • Loading branch information
@khalidmammadov
khalidmammadov committed Jan 31, 2022
commit 59879b5bea06959b2a51ea4fe7285166e09be445
1 change: 1 addition & 0 deletions contributing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,7 @@ Example: `Fix typos in Foo scaladoc`
`[email protected]` first before proceeding to implement the change.

<h3>Pull request</h3>

Before creating a pull request in Apache Spark, it is important to check if tests can pass on your branch because
our GitHub Actions workflows automatically run tests for your pull request/following commits
and every run burdens the limited resources of GitHub Actions in Apache Spark repository.
Expand Down
1 change: 1 addition & 0 deletions site/contributing.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,6 +502,7 @@ <h3>JIRA</h3>
</ol>

<h3>Pull request</h3>

<p>Before creating a pull request in Apache Spark, it is important to check if tests can pass on your branch because
our GitHub Actions workflows automatically run tests for your pull request/following commits
and every run burdens the limited resources of GitHub Actions in Apache Spark repository.
Expand Down