Skip to content

Commit a22d13e

Browse files
committed
addressed feedback
1 parent 5f1cc66 commit a22d13e

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Canonicalize.scala

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ package org.apache.spark.sql.catalyst.expressions
2626
*
2727
* The following rules are applied:
2828
* - Names and nullability hints for [[org.apache.spark.sql.types.DataType]]s are stripped.
29+
* - Names for [[org.apache.spark.sql.catalyst.expressions.GetStructField]] are stripped.
2930
* - Commutative and associative operations ([[Add]] and [[Multiply]]) have their children ordered
3031
* by `hashCode`.
3132
* - [[EqualTo]] and [[EqualNullSafe]] are reordered by `hashCode`.
@@ -37,7 +38,7 @@ object Canonicalize {
3738
expressionReorder(ignoreNamesTypes(e))
3839
}
3940

40-
/** Remove names and/or nullability from types. */
41+
/** Remove names and nullability from types, and names from `GetStructField` */
4142
private[expressions] def ignoreNamesTypes(e: Expression): Expression = e match {
4243
case a: AttributeReference =>
4344
AttributeReference("none", a.dataType.asNullable)(exprId = a.exprId)

0 commit comments

Comments
 (0)