Skip to content

[SPARK-12158] [SparkR] [SQL] Fix 'sample' functions that break R unit test cases #10160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gatorsmile wants to merge 7 commits into from
Closed

[SPARK-12158] [SparkR] [SQL] Fix 'sample' functions that break R unit test cases #10160

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ec77010
add sample functions with seeds
gatorsmile Dec 5, 2015
2ab89e8
combine two variants
gatorsmile Dec 6, 2015
34d0118
added a test case
gatorsmile Dec 7, 2015
4337c35
simplified the impl of sample_frac
gatorsmile Dec 7, 2015
a78109e
simplified the impl of sample_frac.
gatorsmile Dec 7, 2015
ad3ea31
Merge remote-tracking branch 'upstream/master' into sampleR
gatorsmile Dec 7, 2015
493b368
added a new parm into the comment
gatorsmile Dec 7, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added a test case
  • Loading branch information
@gatorsmile
gatorsmile committed Dec 7, 2015
commit 34d01188485ac375c811362af32e9b9aad872631
4 changes: 4 additions & 0 deletions R/pkg/inst/tests/test_sparkSQL.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,6 +705,10 @@ test_that("sample on a DataFrame", {
sampled2 <- sample(df, FALSE, 0.1, 0) # set seed for predictable result
expect_true(count(sampled2) < 3)

count1 <- count(sample(df, FALSE, 0.1, 0))
count2 <- count(sample(df, FALSE, 0.1, 0))
expect_equal(count1, count2)

# Also test sample_frac
sampled3 <- sample_frac(df, FALSE, 0.1, 0) # set seed for predictable result
expect_true(count(sampled3) < 3)
Expand Down