Skip to content

Conversation

@JoshRosen
Copy link
Contributor

The Scala 2.11 SBT build currently fails for Spark 1.6.0 and master due to warnings about the @transient annotation:

[error] [warn] /Users/joshrosen/Documents/spark/extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisBackedBlockRDD.scala:73: no valid targets for annotation on value sc - it is discarded unused. You may specify targets with meta-annotations, e.g. @(transient @param)
[error] [warn]     @transient sc: SparkContext,

This fix implemented here is the same as what we did in #8433: remove the @transient annotations when they are not necessary and replace use @transient private val in the remaining cases.

@SparkQA
Copy link

SparkQA commented Dec 26, 2015

Test build #48330 has finished for PR 10479 at commit 0b79c39.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 26, 2015

Test build #48332 has finished for PR 10479 at commit 70e7032.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 26, 2015

Test build #48333 has finished for PR 10479 at commit afe11f2.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 26, 2015

Test build #48334 has finished for PR 10479 at commit 0a3f671.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Dec 28, 2015

LGTM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skyluc @rxin, according to #8433 "if the class parameter are used in methods, then fields are created." I'm not sure how this applies in this case, where blockIds is also the name of a field in the superclass. In #8433, it looks like the fix was just to rename blockIds to _blockIds in order to avoid any ambiguity (see c1bc4f4#diff-b936e296c84502986961fb815d642458L64). Therefore, I'm going to make the same fix here for consistency's sake.

@JoshRosen
Copy link
Contributor Author

I'm only planning to merge this into 2.0.0.

@rxin
Copy link
Contributor

rxin commented Dec 28, 2015

LGTM

@JoshRosen
Copy link
Contributor Author

Jenkins, retest this please.

1 similar comment
@JoshRosen
Copy link
Contributor Author

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Dec 28, 2015

Test build #48376 has finished for PR 10479 at commit 422ef49.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@asfgit asfgit closed this in fb572c6 Dec 28, 2015
@JoshRosen JoshRosen deleted the fix-sbt-2.11 branch December 28, 2015 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants