-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-12537] [SQL] Add option to accept quoting of all character backslash quoting mechanism #10497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
recreate pull request(10496->10497) |
|
In general you do not need to open a new pull request. But before you make a PR, best to finish the questions on the JIRA. I'm not yet clear why this is regularly needed, or when |
python/pyspark/sql/readwriter.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think you need the trailing \ yet
|
Changed default value to true and remove \ in comment |
|
Test build #2264 has finished for PR 10497 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This default should be false, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy New Year Owen!
At first, I've created PR with false default.
But Xin advised to me that "I'd actually change the default value to true" in previous comment so I've changed.
If you think it doesn't make sense, please call me again. I will change that immediately
Thank you
|
Could I ask to run test? |
|
Test build #2308 has finished for PR 10497 at commit
|
|
I've merged this. Thanks! |
|
@Cazen you probably want to add this email to your github profile so the commit shows up under your account: [email protected] |
|
Thank you @rxin I've added my email address to github profile. |
We can provides the option to choose JSON parser can be enabled to accept quoting of all character or not.