Skip to content

Conversation

@yucai
Copy link
Contributor

@yucai yucai commented Dec 30, 2015

[SPARK-12582][Test] IndexShuffleBlockResolverSuite fails in windows

  • IndexShuffleBlockResolverSuite fails in windows due to file is not closed.
  • mv IndexShuffleBlockResolverSuite.scala from "test/java" to "test/scala".

https://issues.apache.org/jira/browse/SPARK-12582

* IndexShuffleBlockResolverSuite fails in windows due to file is not closed.
* mv IndexShuffleBlockResolverSuite.scala from "test/java" to "test/scala".
@chenghao-intel
Copy link
Contributor

LGTM @andrewor14

@yucai yucai changed the title [SPARK-12582][shuffle]IndexShuffleBlockResolverSuite fails in windows [SPARK-12582][Test]IndexShuffleBlockResolverSuite fails in windows Dec 30, 2015
@yucai yucai changed the title [SPARK-12582][Test]IndexShuffleBlockResolverSuite fails in windows [SPARK-12582][Test] IndexShuffleBlockResolverSuite fails in windows Dec 30, 2015
@andrewor14
Copy link
Contributor

Looks good, but maybe we should close the stream in a finally block.
ok to test

@srowen
Copy link
Member

srowen commented Jan 2, 2016

@yucai can you update accordingly?

@yucai
Copy link
Contributor Author

yucai commented Jan 3, 2016

Sure, I will update the codes.

@JoshRosen
Copy link
Contributor

Ping again; should be quick to update then we can merge.

@andrewor14
Copy link
Contributor

Jenkins, this is ok to test?

@SparkQA
Copy link

SparkQA commented Jan 6, 2016

Test build #48801 has finished for PR 10526 at commit 11b97d5.

  • This patch fails from timeout after a configured wait of 250m.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class IndexShuffleBlockResolverSuite extends SparkFunSuite with BeforeAndAfterEach

@SparkQA
Copy link

SparkQA commented Jan 8, 2016

Test build #2352 has finished for PR 10526 at commit 11b97d5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class IndexShuffleBlockResolverSuite extends SparkFunSuite with BeforeAndAfterEach

@srowen
Copy link
Member

srowen commented Jan 10, 2016

@yucai should we take this over, in which case you can close this PR, or do you intend to update it?

@yucai
Copy link
Contributor Author

yucai commented Jan 11, 2016

Sorry, I miss the conversation! I will update it right now.

@SparkQA
Copy link

SparkQA commented Jan 11, 2016

Test build #49088 has finished for PR 10526 at commit fb9cb7d.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yucai
Copy link
Contributor Author

yucai commented Jan 11, 2016

Jenkins, retest this please.

1 similar comment
@JoshRosen
Copy link
Contributor

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Jan 11, 2016

Test build #49098 has finished for PR 10526 at commit 174b40f.

  • This patch fails from timeout after a configured wait of 250m.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 11, 2016

Test build #49121 has finished for PR 10526 at commit 174b40f.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 11, 2016

Test build #2362 has finished for PR 10526 at commit 174b40f.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor

retest this please

@SparkQA
Copy link

SparkQA commented Jan 11, 2016

Test build #49173 has finished for PR 10526 at commit 174b40f.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JoshRosen
Copy link
Contributor

Looks like a known-flaky streaming test.

@yucai
Copy link
Contributor Author

yucai commented Jan 12, 2016

One failure is about flaky streaming test. I retest InputStreamsSuite locally, no failure.

[info] - socket input stream *** FAILED *** (3 seconds, 978 milliseconds)
[info]   4 did not equal 5 (InputStreamsSuite.scala:83)
[info]   org.scalatest.exceptions.TestFailedException:
[info]   at org.scalatest.Assertions$class.newAssertionFailedException(Assertions.scala:500)
[info]   at org.scalatest.FunSuite.newAssertionFailedException(FunSuite.scala:1555)
[info]   at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:466)

Another failure looks like some test fail to launch? Like below:

[error] Error: Total 0, Failed 0, Errors 0, Passed 0
[error] Error during tests:
[error]     Running java with options -classpath /home/jenkins/workspace/SparkPullRequestBuilder/core/target/scala-2.10/test-classes:/home/jenkins/workspace/SparkPullRequestBuilder/core/target/scala-2.10/classes:/home/jenkins/workspace/SparkPullRequestBuilder/launcher/target/scala-2.10/classes:/home/jenkins/workspace/SparkPullRequestBuilder/network/common/target/scala-2.10/classes:/home/jenkins/workspace/SparkPullRequestBuilder/network/shuffle/target/scala-

How about retest this?

@yucai
Copy link
Contributor Author

yucai commented Jan 12, 2016

@JoshRosen @andrewor14 could you kindly help retest?

@JoshRosen
Copy link
Contributor

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Jan 12, 2016

Test build #49210 has finished for PR 10526 at commit 174b40f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jan 12, 2016

Merged to master/1.6

asfgit pushed a commit that referenced this pull request Jan 12, 2016
[SPARK-12582][Test] IndexShuffleBlockResolverSuite fails in windows

* IndexShuffleBlockResolverSuite fails in windows due to file is not closed.
* mv IndexShuffleBlockResolverSuite.scala from "test/java" to "test/scala".

https://issues.apache.org/jira/browse/SPARK-12582

Author: Yucai Yu <[email protected]>

Closes #10526 from yucai/master.

(cherry picked from commit 7e15044)
Signed-off-by: Sean Owen <[email protected]>
@asfgit asfgit closed this in 7e15044 Jan 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants