Skip to content

[SPARK-12533][SQL] hiveContext.table() throws the wrong exception #10529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thomastechs wants to merge 7 commits into from
Closed

[SPARK-12533][SQL] hiveContext.table() throws the wrong exception #10529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c833cae
Update Catalog.scala
thomastechs Dec 30, 2015
4463a95
Update Catalog.scala- [SPARK-12533]
thomastechs Dec 31, 2015
9e8797e
Updated Catalog.scala with standard message
thomastechs Jan 1, 2016
6639956
Updated Analyzer.scala with the AnalysisException
thomastechs Jan 1, 2016
76a9623
[SPARK-12438][SQL]Updating CachedTableSuite.scala
thomastechs Jan 1, 2016
f74a9a2
[SPARK-12533]Updated CachedTableSuite.scala
thomastechs Jan 2, 2016
f75c44e
[SPARK-12533]Updated Analyzer.scala
thomastechs Jan 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Catalog.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ class SimpleCatalog(val conf: CatalystConf) extends Catalog {
val tableName = getTableName(tableIdent)
val table = tables.get(tableName)
if (table == null) {
throw new NoSuchTableException
throw new AnalysisException("Table not found: " + tableName)
Copy link
Contributor

@marmbrus marmbrus Jan 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that NoSuchTableException is not used anywhere? We should probably get rid of it then. Though, I think I'd have a slight preference for keeping a special exception internally. The point of this extra control flow is so that we can attach line position information to this specific exception in the analyzer.

Copy link
Contributor

@dilipbiswal dilipbiswal Jan 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marmbrus Shouldn't we have fixed this issue by marking the relation unresolved and let the analyzer generate a proper AnalysisException ? If we were to use the catalog interface for some other purpose like tooling etc keeping the generic catalog exceptions would have been better ?

}
val tableWithQualifiers = Subquery(tableName, table)

Expand Down
6 changes: 3 additions & 3 deletions sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

package org.apache.spark.sql

import org.apache.spark.sql.catalyst.analysis.NoSuchTableException

import org.apache.spark.sql.execution.Exchange
import org.apache.spark.sql.execution.PhysicalRDD

Expand Down Expand Up @@ -289,7 +289,7 @@ class CachedTableSuite extends QueryTest with SQLTestUtils with SharedSQLContext
testData.select('key).registerTempTable("t1")
sqlContext.table("t1")
sqlContext.dropTempTable("t1")
intercept[NoSuchTableException](sqlContext.table("t1"))
intercept[AnalysisException](sqlContext.table("t1"))
}

test("Drops cached temporary table") {
Expand All @@ -301,7 +301,7 @@ class CachedTableSuite extends QueryTest with SQLTestUtils with SharedSQLContext
assert(sqlContext.isCached("t2"))

sqlContext.dropTempTable("t1")
intercept[NoSuchTableException](sqlContext.table("t1"))
intercept[AnalysisException](sqlContext.table("t1"))
assert(!sqlContext.isCached("t2"))
}

Expand Down