Skip to content

[SPARK-12662][SQL] Fix DataFrame.randomSplit to avoid creating overlapping splits #10626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sameeragarwal wants to merge 7 commits into from
Closed

[SPARK-12662][SQL] Fix DataFrame.randomSplit to avoid creating overlapping splits #10626

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
27288a3
Fix DataFrame.randomSplit to avoid creating overlapping splits
sameeragarwal Jan 7, 2016
6336832
Reynold's comments
sameeragarwal Jan 7, 2016
8c3293c
s/logicalPlanWithLocalSort/sorted
sameeragarwal Jan 7, 2016
be9630f
test for single seed
sameeragarwal Jan 7, 2016
56d9bd7
single seed + check for deterministic results across multiple runs
sameeragarwal Jan 7, 2016
3af6a2d
Remove size checks
sameeragarwal Jan 7, 2016
1b30119
Simplify test
sameeragarwal Jan 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
single seed + check for deterministic results across multiple runs
  • Loading branch information
@sameeragarwal
sameeragarwal committed Jan 7, 2016
commit 56d9bd7f05d0d294826ae541e0725d92eeeb0b08
6 changes: 6 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/DataFrameStatSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,16 @@ class DataFrameStatSuite extends QueryTest with SharedSQLContext {
s"split $id overlaps with split ${(id + 1) % splits.length}")
}

// Verify sample sizes
val s = splits.map(_.count())
assert(math.abs(s(0) - 100) < 50) // std = 9.13
assert(math.abs(s(1) - 200) < 50) // std = 11.55
assert(math.abs(s(2) - 300) < 50) // std = 12.25

// Verify that the results are deterministic across multiple runs
val firstRun = splits.toSeq.map(_.collect().toSeq)
val secondRun = data.randomSplit(Array[Double](1, 2, 3), seed = 1).toSeq.map(_.collect().toSeq)
assert(firstRun == secondRun)
}

test("pearson correlation") {
Expand Down