Skip to content

[SPARK-12934] use try-with-resources for streams #10906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tedyu wants to merge 2 commits into from
Closed

[SPARK-12934] use try-with-resources for streams #10906

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e400a17
[SPARK-12934] use try-with-resources for streams
tedyu Jan 25, 2016
860d3ba
Address review comments by documenting
tedyu Jan 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions common/sketch/src/main/java/org/apache/spark/util/sketch/CountMinSketch.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,11 +128,13 @@ public abstract CountMinSketch mergeInPlace(CountMinSketch other)

/**
* Writes out this {@link CountMinSketch} to an output stream in binary format.
* It is the caller's responsibility to close the stream
*/
public abstract void writeTo(OutputStream out) throws IOException;

/**
* Reads in a {@link CountMinSketch} from an input stream.
* It is the caller's responsibility to close the stream
*/
public static CountMinSketch readFrom(InputStream in) throws IOException {
return CountMinSketchImpl.readFrom(in);
Expand Down