Skip to content

[SPARK-13139][SQL] Create native DDL commands #11048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
viirya wants to merge 20 commits into from
Closed

[SPARK-13139][SQL] Create native DDL commands #11048

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
77252af
init import: create database and create function.
viirya Feb 3, 2016
2b38d11
Fix import order.
viirya Feb 3, 2016
cee8056
Merge remote-tracking branch 'upstream/master' into native-ddl
viirya Feb 8, 2016
127a684
alter table command.
viirya Feb 5, 2016
f9c1397
Fix it.
viirya Feb 8, 2016
eb1fab7
Fix style.
viirya Feb 8, 2016
3db2e1d
List TOK_ALTERTABLE as not explanable command.
viirya Feb 9, 2016
8a7d34e
Merge remote-tracking branch 'upstream/master' into native-ddl
viirya Feb 15, 2016
2e78f52
Add execution.commands package.
viirya Feb 15, 2016
170bd77
Refactor.
viirya Feb 15, 2016
4a96331
Fix scala style.
viirya Feb 16, 2016
3c2fc25
Fix import.
viirya Feb 16, 2016
461d163
Merge remote-tracking branch 'upstream/master' into native-ddl
viirya Feb 22, 2016
bcf3f28
Address comments.
viirya Feb 22, 2016
0c57651
Delete moved files.
viirya Feb 22, 2016
54c0578
Fix scala style.
viirya Feb 23, 2016
0eb1687
Merge remote-tracking branch 'upstream/master' into native-ddl
viirya Feb 23, 2016
5f8e70d
Merge remote-tracking branch 'upstream/master' into native-ddl
viirya Feb 25, 2016
53d02f0
Merge remote-tracking branch 'upstream/master' into native-ddl
viirya Feb 26, 2016
6032268
Merge remote-tracking branch 'upstream/master' into native-ddl
viirya Mar 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
List TOK_ALTERTABLE as not explanable command.
  • Loading branch information
@viirya
viirya committed Feb 9, 2016
commit 3db2e1d867b5750eb157c751a303c542bdad110e
5 changes: 3 additions & 2 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ import org.apache.spark.sql.types.StructType

private[sql] class SparkQl(conf: ParserConf = SimpleParserConf()) extends CatalystQl(conf) {
/** Check if a command should not be explained. */
protected def isNoExplainCommand(command: String): Boolean = "TOK_DESCTABLE" == command
protected def isNoExplainCommand(command: String): Boolean =
"TOK_DESCTABLE" == command || "TOK_ALTERTABLE" == command

protected override def nodeToPlan(node: ASTNode): LogicalPlan = {
node match {
Expand All @@ -55,7 +56,7 @@ private[sql] class SparkQl(conf: ParserConf = SimpleParserConf()) extends Cataly
getClauses(Seq("TOK_CREATETABLE", "FORMATTED", "EXTENDED"), explainArgs)
ExplainCommand(nodeToPlan(crtTbl), extended = extended.isDefined)

case Token("TOK_EXPLAIN", explainArgs) =>
case Token("TOK_EXPLAIN", explainArgs) if "TOK_QUERY" == explainArgs.head.text =>
Copy link
Contributor

@hvanhovell hvanhovell Feb 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not Token("TOK_EXPLAIN", Token("TOK_QUERY", query) :: explainArgs) => ?

Copy link
Contributor

@hvanhovell hvanhovell Feb 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there other EXPLAIN cases possible?

// Ignore FORMATTED if present.
val Some(query) :: _ :: extended :: Nil =
getClauses(Seq("TOK_QUERY", "FORMATTED", "EXTENDED"), explainArgs)
Expand Down
3 changes: 2 additions & 1 deletion sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,8 @@ private[hive] class HiveQl(conf: ParserConf) extends SparkQl(conf) with Logging
protected val noExplainCommands = Seq(
"TOK_DESCTABLE",
"TOK_SHOWTABLES",
"TOK_TRUNCATETABLE" // truncate table" is a NativeCommand, does not need to explain.
"TOK_TRUNCATETABLE", // truncate table" is a NativeCommand, does not need to explain.
"TOK_ALTERTABLE"
) ++ nativeCommands

/**
Expand Down