Skip to content

Conversation

@yanboliang
Copy link
Contributor

What changes were proposed in this pull request?

Remove duplicated periods at the end of some sharedParams in ScalaDoc, such as here
cc @mengxr @srowen

How was this patch tested?

Documents change, no test.

@yanboliang yanboliang changed the title [] [] [] Clean up sharedParams [Minor] [ML] [Doc] Clean up sharedParams Feb 24, 2016
@yanboliang yanboliang changed the title [Minor] [ML] [Doc] Clean up sharedParams [Minor] [ML] [Doc] Clean up dots at the end of some sharedParams Feb 24, 2016
@yanboliang yanboliang changed the title [Minor] [ML] [Doc] Clean up dots at the end of some sharedParams [Minor] [ML] [Doc] Cleanup dots at the end of some sharedParam Feb 24, 2016
@srowen
Copy link
Member

srowen commented Feb 24, 2016

@yanboliang this isn't worth changing. The period isn't hurting anything

@SparkQA
Copy link

SparkQA commented Feb 24, 2016

Test build #51870 has finished for PR 11344 at commit a12b1ac.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • final val thresholds: DoubleArrayParam = new DoubleArrayParam(this, \"thresholds\", \"Thresholds in multi-class classification to adjust the probability of predicting each class. Array must have length equal to the number of classes, with values >= 0. The class with largest value p/t is predicted, where p is the original probability of that class and t is the class' threshold\", (t: Array[Double]) => t.forall(_ >= 0))

@yanboliang
Copy link
Contributor Author

@srowen Some ScalaDocs will end with two periods if we don't fix, you can refer here.

@SparkQA
Copy link

SparkQA commented Feb 24, 2016

Test build #51881 has finished for PR 11344 at commit a12b1ac.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • final val thresholds: DoubleArrayParam = new DoubleArrayParam(this, \"thresholds\", \"Thresholds in multi-class classification to adjust the probability of predicting each class. Array must have length equal to the number of classes, with values >= 0. The class with largest value p/t is predicted, where p is the original probability of that class and t is the class' threshold\", (t: Array[Double]) => t.forall(_ >= 0))

@yanboliang
Copy link
Contributor Author

Jenkins, test this please.

@yanboliang yanboliang changed the title [Minor] [ML] [Doc] Cleanup dots at the end of some sharedParam [Minor] [ML] [Doc] Remove duplicated periods at the end of some sharedParam Feb 25, 2016
@SparkQA
Copy link

SparkQA commented Feb 25, 2016

Test build #51970 has finished for PR 11344 at commit a12b1ac.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • final val thresholds: DoubleArrayParam = new DoubleArrayParam(this, \"thresholds\", \"Thresholds in multi-class classification to adjust the probability of predicting each class. Array must have length equal to the number of classes, with values >= 0. The class with largest value p/t is predicted, where p is the original probability of that class and t is the class' threshold\", (t: Array[Double]) => t.forall(_ >= 0))

@jkbradley
Copy link
Member

May not be worth it, but I think it's fine to fix. LGTM I'll merge this with master

@asfgit asfgit closed this in ce58e99 Mar 3, 2016
@yanboliang yanboliang deleted the shared-cleanup branch March 4, 2016 01:58
roygao94 pushed a commit to roygao94/spark that referenced this pull request Mar 22, 2016
…aram

## What changes were proposed in this pull request?
Remove duplicated periods at the end of some sharedParams in ScalaDoc, such as [here](https://github.com/apache/spark/pull/11344/files#diff-9edc669edcf2c0c7cf1efe4a0a57da80L367)
cc mengxr srowen
## How was this patch tested?
Documents change, no test.

Author: Yanbo Liang <[email protected]>

Closes apache#11344 from yanboliang/shared-cleanup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants