Skip to content

[SPARK-12874][ML] ML StringIndexer does not protect itself from column name duplication #11370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yu-iskw wants to merge 1 commit into from
Closed

[SPARK-12874][ML] ML StringIndexer does not protect itself from column name duplication #11370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ class StringIndexerModel (
"Skip StringIndexerModel.")
return dataset
}
validateAndTransformSchema(dataset.schema)

val indexer = udf { label: String =>
if (labelToIndex.contains(label)) {
Expand Down
11 changes: 11 additions & 0 deletions mllib/src/test/scala/org/apache/spark/ml/feature/StringIndexerSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,17 @@ class StringIndexerSuite
assert(indexerModel.transform(df).eq(df))
}

test("StringIndexerModel can't overwrite output column") {
val df = sqlContext.createDataFrame(Seq((1, 2), (3, 4))).toDF("input", "output")
val indexer = new StringIndexer()
.setInputCol("input")
.setOutputCol("output")
.fit(df)
intercept[IllegalArgumentException] {
indexer.transform(df)
}
}

test("StringIndexer read/write") {
val t = new StringIndexer()
.setInputCol("myInputCol")
Expand Down