Skip to content

[SPARK-13495][SQL] Add Null Filters in the query plan for Filters/Joins based on their data constraints #11372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sameeragarwal wants to merge 7 commits into from
Closed

[SPARK-13495][SQL] Add Null Filters in the query plan for Filters/Joins based on their data constraints #11372

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cc4323f
NullFiltering rule in catalyst
sameeragarwal Feb 25, 2016
28050b3
unit tests
sameeragarwal Mar 2, 2016
0b1520c
Fix OrcFilterSuite
sameeragarwal Mar 3, 2016
2a469e8
Fix SimpleTextHadoopFsRelationSuite
sameeragarwal Mar 3, 2016
80dab7e
Add isNotNull handling in SimpleTextRelation
sameeragarwal Mar 3, 2016
013f97a
Fix PlannerSuite and ParquetFilterSuite
sameeragarwal Mar 3, 2016
31b1700
Nong's comments
sameeragarwal Mar 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix OrcFilterSuite
  • Loading branch information
@sameeragarwal
sameeragarwal committed Mar 3, 2016
commit 0b1520c6ec38e2c505335e70e248abc27efccd6f
16 changes: 9 additions & 7 deletions sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcFilterSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ class OrcFilterSuite extends QueryTest with OrcTest {
(predicate: Predicate, filterOperator: PredicateLeaf.Operator)
(implicit df: DataFrame): Unit = {
def checkComparisonOperator(filter: SearchArgument) = {
val operator = filter.getLeaves.asScala.head.getOperator
assert(operator === filterOperator)
val operator = filter.getLeaves.asScala
assert(operator.map(_.getOperator).contains(filterOperator))
}
checkFilterPredicate(df, predicate, checkComparisonOperator)
}
Expand Down Expand Up @@ -216,8 +216,9 @@ class OrcFilterSuite extends QueryTest with OrcTest {
)
checkFilterPredicate(
!('_1 < 4),
"""leaf-0 = (LESS_THAN _1 4)
|expr = (not leaf-0)""".stripMargin.trim
"""leaf-0 = (IS_NULL _1)
|leaf-1 = (LESS_THAN _1 4)
|expr = (and (not leaf-0) (not leaf-1))""".stripMargin.trim
)
checkFilterPredicate(
'_1 < 2 || '_1 > 3,
Expand All @@ -227,9 +228,10 @@ class OrcFilterSuite extends QueryTest with OrcTest {
)
checkFilterPredicate(
'_1 < 2 && '_1 > 3,
"""leaf-0 = (LESS_THAN _1 2)
|leaf-1 = (LESS_THAN_EQUALS _1 3)
|expr = (and leaf-0 (not leaf-1))""".stripMargin.trim
"""leaf-0 = (IS_NULL _1)
|leaf-1 = (LESS_THAN _1 2)
|leaf-2 = (LESS_THAN_EQUALS _1 3)
|expr = (and (not leaf-0) leaf-1 (not leaf-2))""".stripMargin.trim
)
}
}
Expand Down