[SPARK-12042] Python API for mllib.stat.test.StreamingTest #11374
Conversation
|
cc: @feynmanliang |
|
Test build #51989 has finished for PR 11374 at commit
|
|
test it please |
|
Test build #52523 has finished for PR 11374 at commit
|
|
Test build #58598 has finished for PR 11374 at commit
|
|
Any updates to this PR? |
|
Test build #67696 has finished for PR 11374 at commit
|
|
I'll review this tonight |
|
Apologies for the delay, I am traveling but I'll get this done this weekend. |
feynmanliang
left a comment
feynmanliang
left a comment
There was a problem hiding this comment.
Did a first pass.
It's been awhile since I've looked at PySpark so I may be a bit rusty on some things.
|
|
||
| """ | ||
| Create a DStream that contains several RDDs to show the StreamingTest of PySpark. | ||
| """ |
There was a problem hiding this comment.
Seems like other examples are including a from __future__ import print_function here
| sc = SparkContext(appName="PythonStreamingTestExample") | ||
| ssc = StreamingContext(sc, 1) | ||
|
|
||
| checkpoint_path = tempfile.mkdtemp() |
| from pyspark.mllib.stat.test import BinarySample, StreamingTest | ||
|
|
||
| if __name__ == "__main__": | ||
|
|
There was a problem hiding this comment.
nit: don't include newline here
|
|
||
| from pyspark import SparkContext | ||
| from pyspark.streaming import StreamingContext | ||
| from pyspark.mllib.stat.test import BinarySample, StreamingTest |
There was a problem hiding this comment.
$example on$ and $example off appear to be used in other examples, though I'm not sure why myself
| ssc.checkpoint(checkpoint_path) | ||
|
|
||
| # Create the queue through which RDDs can be pushed to a QueueInputDStream. | ||
| rdd_queue = [] |
There was a problem hiding this comment.
use camelCase to be consistent with other examples
| """ | ||
|
|
||
| checkpoint_path = tempfile.mkdtemp() | ||
| self.ssc.checkpoint(checkpoint_path) |
| input_stream = self.ssc.queueStream(rdd_queue) | ||
|
|
||
| model = StreamingTest() | ||
| model.setPeacePeriod(1) |
There was a problem hiding this comment.
Can we break this into another test just for model params like
spark/python/pyspark/mllib/tests.py
Line 1165 in 39e2bad
| } | ||
| } | ||
|
|
||
| private[python] class StreamingTestResultPickler extends BasePickler[StreamingTestResult] { |
There was a problem hiding this comment.
Do we need to test these in PythonMLLibAPISuite?
| streamingTest.setTestMethod(self._testMethod) | ||
|
|
||
| javaDStream = sc._jvm.SerDe.pythonToJava(data._jdstream, True) | ||
| testResult = streamingTest.registerStream(javaDStream) |
There was a problem hiding this comment.
Why do we need pythonToJava and javaToPython; its not used for streaming K means
spark/python/pyspark/mllib/clustering.py
Line 773 in 39e2bad
| */ | ||
| @Since("1.6.0") | ||
| private[stat] class StreamingTestResult @Since("1.6.0") ( | ||
| class StreamingTestResult @Since("1.6.0") ( |
There was a problem hiding this comment.
Does this need to be public? Java API doesn't seem to require it
|
Hi @yinxusen, are you able to proceed this further? If not, it seems it might be better closed for now. |
## What changes were proposed in this pull request? This PR proposes to close stale PRs. What I mean by "stale" here includes that there are some review comments by reviewers but the author looks inactive without any answer to them more than a month. I left some comments roughly a week ago to ping and the author looks still inactive in these PR below These below includes some PR suggested to be closed and a PR against another branch which seems obviously inappropriate. Given the comments in the last three PRs below, they are probably worth being taken over by anyone who is interested in it. Closes apache#7963 Closes apache#8374 Closes apache#11192 Closes apache#11374 Closes apache#11692 Closes apache#12243 Closes apache#12583 Closes apache#12620 Closes apache#12675 Closes apache#12697 Closes apache#12800 Closes apache#13715 Closes apache#14266 Closes apache#15053 Closes apache#15159 Closes apache#15209 Closes apache#15264 Closes apache#15267 Closes apache#15871 Closes apache#15861 Closes apache#16319 Closes apache#16324 Closes apache#16890 Closes apache#12398 Closes apache#12933 Closes apache#14517 ## How was this patch tested? N/A Author: hyukjinkwon <[email protected]> Closes apache#16937 from HyukjinKwon/stale-prs-close.
6 participants
What changes were proposed in this pull request?
The patch adds python API for mllib.stat.test.StreamingTest under JIRA https://issues.apache.org/jira/browse/SPARK-12042.
Note that for
StreamingTestResult, unlike other test results in Python, I define it as a normal Python class which doesn't extend fromTestResultwith a_java_objin it.How was this patch tested?
The patch is tested with Python unit test.