Skip to content

[SPARK-13523] [SQL] Reuse exchanges in a query #11403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davies wants to merge 6 commits into from
Closed

[SPARK-13523] [SQL] Reuse exchanges in a query #11403

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
57866c2
WIP: reuse exchanges in a query
Feb 26, 2016
f6a7f5c
fix style
Mar 4, 2016
3cc23f3
fix flakyness of sameResult
Mar 4, 2016
679d669
Merge branch 'master' of github.com:apache/spark into dedup
Mar 8, 2016
7df43ca
address comments
Mar 8, 2016
7cd6844
address comments
Mar 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix flakyness of sameResult
  • Loading branch information
Davies Liu committed Mar 4, 2016
commit 3cc23f3d94e744a96a2f5c1de9d3ebc67ec917e8
6 changes: 3 additions & 3 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,15 +276,15 @@ abstract class QueryPlan[PlanType <: QueryPlan[PlanType]] extends TreeNode[PlanT
// to erase that for equality testing.
val cleanedExprId =
Alias(a.child, a.name)(ExprId(-1), a.qualifiers, isGenerated = a.isGenerated)
BindReferences.bindReference(cleanedExprId.canonicalized, allAttributes, allowFailures = true)
BindReferences.bindReference(cleanedExprId, allAttributes, allowFailures = true)
case other =>
BindReferences.bindReference(other.canonicalized, allAttributes, allowFailures = true)
BindReferences.bindReference(other, allAttributes, allowFailures = true)
}

/** Args that have cleaned such that differences in expression id should not affect equality */
protected lazy val cleanArgs: Seq[Any] = {
def cleanArg(arg: Any): Any = arg match {
case e: Expression => cleanExpression(e)
case e: Expression => cleanExpression(e).canonicalized
case other => other
}

Expand Down