[SPARK-13601] call failure callbacks before writer.close() #11450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test build #52255 has finished for PR 11450 at commit
|
|
Test build #52258 has finished for PR 11450 at commit
|
Contributor
|
Thanks for doing this. I took a look and I think we also need to update a few of the places in WriterContainer.scala, because the SQL file-based data sources don't actually go through this pair rdd path. |
Contributor
Author
|
@rxin Added. |
| * exception from the original `out.write` call. | ||
| */ | ||
| def tryWithSafeFinallyAndFailureCallbacks[T](block: => T)(finallyBlock: => Unit): T = { | ||
| // It would be nice to find a method on Try that did this |
Contributor
|
LGTM pending tests. Can you just remove that comment when you merge it? |
|
Test build #52335 has finished for PR 11450 at commit
|
Contributor
Author
|
Merging this into master (comments removed), will cherry-picked into 1.6 later. |
|
Test build #52341 has finished for PR 11450 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Mar 3, 2016
In order to tell OutputStream that the task has failed or not, we should call the failure callbacks BEFORE calling writer.close(). Added new unit tests. Author: Davies Liu <[email protected]> Closes #11450 from davies/callback.
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
## What changes were proposed in this pull request? In order to tell OutputStream that the task has failed or not, we should call the failure callbacks BEFORE calling writer.close(). ## How was this patch tested? Added new unit tests. Author: Davies Liu <[email protected]> Closes apache#11450 from davies/callback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In order to tell OutputStream that the task has failed or not, we should call the failure callbacks BEFORE calling writer.close().
How was this patch tested?
Added new unit tests.