Skip to content

Conversation

@davies
Copy link
Contributor

@davies davies commented Mar 2, 2016

What changes were proposed in this pull request?

TaskContext supports task completion callback, which gets called regardless of task failures. However, there is no way for the listener to know if there is an error. This patch adds a new listener that gets called when a task fails.

How was this patch tested?

New unit test case and integration test case covering the code path

    ## What changes were proposed in this pull request?

    TaskContext supports task completion callback, which gets called regardless of task failures. However, there is no way for the listener to know if ther
e is an error. This patch adds a new listener that gets called when a task fails.

    ## How was the this patch tested?
    New unit test case and integration test case covering the code path

    Author: Reynold Xin <[email protected]>

    Closes apache#11340 from rxin/SPARK-13465.
@davies davies changed the title [SPARK-13465] Add a task failure listener to TaskContext (for 1.6) [SPARK-13465] Add a task failure listener to TaskContext Mar 2, 2016
@rxin
Copy link
Contributor

rxin commented Mar 2, 2016

LGTM

@SparkQA
Copy link

SparkQA commented Mar 3, 2016

Test build #2602 has finished for PR 11478 at commit 7c5f5de.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Mar 3, 2016

Test build #52343 has finished for PR 11478 at commit 7c5f5de.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Mar 3, 2016

Test build #52346 has finished for PR 11478 at commit 83c6e7c.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Mar 3, 2016

Test build #52379 has finished for PR 11478 at commit 4c6e791.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Mar 3, 2016

Test build #2605 has finished for PR 11478 at commit 4c6e791.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@davies
Copy link
Contributor Author

davies commented Mar 3, 2016

Merged into branch 1.6

asfgit pushed a commit that referenced this pull request Mar 3, 2016
## What changes were proposed in this pull request?

TaskContext supports task completion callback, which gets called regardless of task failures. However, there is no way for the listener to know if there is an error. This patch adds a new listener that gets called when a task fails.

## How was this patch tested?

New unit test case and integration test case covering the code path

Author: Davies Liu <[email protected]>

Closes #11478 from davies/add_failure_1.6.
@davies davies closed this Mar 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants