Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
init import.
  • Loading branch information
viirya committed Mar 2, 2016
commit 9c77d73160d0aefb75eb0e5e10670a0e510f958d
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ case class Expand(
child.asInstanceOf[CodegenSupport].produce(ctx, this)
}

override def doConsume(ctx: CodegenContext, input: Seq[ExprCode]): String = {
override def doConsume(ctx: CodegenContext, input: Seq[ExprCode], row: String = null): String = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove the default value for row here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

/*
* When the projections list looks like:
* expr1A, exprB, expr1C
Expand Down
28 changes: 17 additions & 11 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/Sort.scala
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,8 @@ case class Sort(
// Name of sorter variable used in codegen.
private var sorterVariable: String = _

override def consumeUnsafeRow: Boolean = true

override protected def doProduce(ctx: CodegenContext): String = {
val needToSort = ctx.freshName("needToSort")
ctx.addMutableState("boolean", needToSort, s"$needToSort = true;")
Expand Down Expand Up @@ -153,18 +155,22 @@ case class Sort(
""".stripMargin.trim
}

override def doConsume(ctx: CodegenContext, input: Seq[ExprCode]): String = {
val colExprs = child.output.zipWithIndex.map { case (attr, i) =>
BoundReference(i, attr.dataType, attr.nullable)
}
override def doConsume(ctx: CodegenContext, input: Seq[ExprCode], row: String = null): String = {
if (row != null) {
s"$sorterVariable.insertRow((UnsafeRow)$row.copy());"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the copy here? I think the sorter will copy it by itself.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I checked it. Will remove this copy call.

} else {
val colExprs = child.output.zipWithIndex.map { case (attr, i) =>
BoundReference(i, attr.dataType, attr.nullable)
}

ctx.currentVars = input
val code = GenerateUnsafeProjection.createCode(ctx, colExprs)
ctx.currentVars = input
val code = GenerateUnsafeProjection.createCode(ctx, colExprs)

s"""
| // Convert the input attributes to an UnsafeRow and add it to the sorter
| ${code.code}
| $sorterVariable.insertRow(${code.value});
""".stripMargin.trim
s"""
| // Convert the input attributes to an UnsafeRow and add it to the sorter
| ${code.code}
| $sorterVariable.insertRow(${code.value});
""".stripMargin.trim
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,12 @@ trait CodegenSupport extends SparkPlan {
/**
* Which SparkPlan is calling produce() of this one. It's itself for the first SparkPlan.
*/
private var parent: CodegenSupport = null
protected var parent: CodegenSupport = null

/**
* Whether this SparkPlan accepts UnsafeRow as input in consumeChild.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consumeChild -> doConsume

*/
def consumeUnsafeRow: Boolean = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preferUnsafeRow ?


/**
* Returns all the RDDs of InternalRow which generates the input rows.
Expand Down Expand Up @@ -109,7 +114,7 @@ trait CodegenSupport extends SparkPlan {
* Consume the columns generated from current SparkPlan, call it's parent.
*/
final def consume(ctx: CodegenContext, input: Seq[ExprCode], row: String = null): String = {
if (input != null) {
if (input != null && !parent.consumeUnsafeRow) {
assert(input.length == output.length)
}
parent.consumeChild(ctx, this, input, row)
Expand All @@ -125,14 +130,27 @@ trait CodegenSupport extends SparkPlan {
row: String = null): String = {
ctx.freshNamePrefix = variablePrefix
if (row != null) {
ctx.currentVars = null
ctx.INPUT_ROW = row
val evals = child.output.zipWithIndex.map { case (attr, i) =>
BoundReference(i, attr.dataType, attr.nullable).gen(ctx)
val evals: Seq[ExprCode] = if (!consumeUnsafeRow) {
// If this SparkPlan can't consume UnsafeRow and there is an UnsafeRow,
// we extract the columns from the row and call doConsume.
ctx.currentVars = null
ctx.INPUT_ROW = row
child.output.zipWithIndex.map { case (attr, i) =>
BoundReference(i, attr.dataType, attr.nullable).gen(ctx)
}
} else {
// If this SparkPlan consumes UnsafeRow and there is an UnsafeRow,
// we don't need to unpack variables from the row.
Seq.empty
}
val evalCode = if (evals.isEmpty) {
""
} else {
s"${evals.map(_.code).mkString("\n")}"
}
s"""
| ${evals.map(_.code).mkString("\n")}
| ${doConsume(ctx, evals)}
| $evalCode
| ${doConsume(ctx, evals, row)}
""".stripMargin
} else {
doConsume(ctx, input)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass null here.

Expand All @@ -151,7 +169,7 @@ trait CodegenSupport extends SparkPlan {
* # call consume(), which will call parent.doConsume()
* }
*/
protected def doConsume(ctx: CodegenContext, input: Seq[ExprCode]): String = {
protected def doConsume(ctx: CodegenContext, input: Seq[ExprCode], row: String = null): String = {
throw new UnsupportedOperationException
}
}
Expand Down Expand Up @@ -191,17 +209,26 @@ case class InputAdapter(child: SparkPlan) extends LeafNode with CodegenSupport {
val input = ctx.freshName("input")
// Right now, InputAdapter is only used when there is one upstream.
ctx.addMutableState("scala.collection.Iterator", input, s"$input = inputs[0];")

val exprs = output.zipWithIndex.map(x => new BoundReference(x._2, x._1.dataType, true))
val row = ctx.freshName("row")
ctx.INPUT_ROW = row
ctx.currentVars = null
val columns = exprs.map(_.gen(ctx))

val columns: Seq[ExprCode] = if (!this.parent.consumeUnsafeRow) {
val exprs = output.zipWithIndex.map(x => new BoundReference(x._2, x._1.dataType, true))
ctx.INPUT_ROW = row
ctx.currentVars = null
exprs.map(_.gen(ctx))
} else {
Seq.empty
}
val columnsCode = if (columns.isEmpty) {
""
} else {
s"${columns.map(_.code).mkString("\n").trim}"
}
s"""
| while ($input.hasNext()) {
| InternalRow $row = (InternalRow) $input.next();
| ${columns.map(_.code).mkString("\n").trim}
| ${consume(ctx, columns).trim}
| $columnsCode
| ${consume(ctx, columns, row).trim}
| if (shouldStop()) {
| return;
| }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ case class TungstenAggregate(
}
}

override def doConsume(ctx: CodegenContext, input: Seq[ExprCode]): String = {
override def doConsume(ctx: CodegenContext, input: Seq[ExprCode], row: String = null): String = {
if (groupingExpressions.isEmpty) {
doConsumeWithoutKeys(ctx, input)
} else {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ case class Project(projectList: Seq[NamedExpression], child: SparkPlan)
child.asInstanceOf[CodegenSupport].produce(ctx, this)
}

override def doConsume(ctx: CodegenContext, input: Seq[ExprCode]): String = {
override def doConsume(ctx: CodegenContext, input: Seq[ExprCode], row: String = null): String = {
val exprs = projectList.map(x =>
ExpressionCanonicalizer.execute(BindReferences.bindReference(x, child.output)))
ctx.currentVars = input
Expand Down Expand Up @@ -77,7 +77,7 @@ case class Filter(condition: Expression, child: SparkPlan) extends UnaryNode wit
child.asInstanceOf[CodegenSupport].produce(ctx, this)
}

override def doConsume(ctx: CodegenContext, input: Seq[ExprCode]): String = {
override def doConsume(ctx: CodegenContext, input: Seq[ExprCode], row: String = null): String = {
val numOutput = metricTerm(ctx, "numOutputRows")
val expr = ExpressionCanonicalizer.execute(
BindReferences.bindReference(condition, child.output))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ case class BroadcastHashJoin(
streamedPlan.asInstanceOf[CodegenSupport].produce(ctx, this)
}

override def doConsume(ctx: CodegenContext, input: Seq[ExprCode]): String = {
override def doConsume(ctx: CodegenContext, input: Seq[ExprCode], row: String = null): String = {
if (joinType == Inner) {
codegenInner(ctx, input)
} else {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ trait BaseLimit extends UnaryNode with CodegenSupport {
child.asInstanceOf[CodegenSupport].produce(ctx, this)
}

override def doConsume(ctx: CodegenContext, input: Seq[ExprCode]): String = {
override def doConsume(ctx: CodegenContext, input: Seq[ExprCode], row: String = null): String = {
val stopEarly = ctx.freshName("stopEarly")
ctx.addMutableState("boolean", stopEarly, s"$stopEarly = false;")

Expand Down