Skip to content

[SPARK-13640][SQL] Synchronize ScalaReflection.mirror method. #11487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ueshin wants to merge 8 commits into from
Closed

[SPARK-13640][SQL] Synchronize ScalaReflection.mirror method. #11487

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b9d99bd
Add a test to check thread safety of ScalaRefection.mirror method.
ueshin Mar 3, 2016
389d644
Synchronize ScalaReflection.mirror method.
ueshin Mar 3, 2016
549b8f8
Modify test to check other methods using reflection.
ueshin Mar 3, 2016
cee5896
Synchronize ScalaReflection.localTypeOf method.
ueshin Mar 3, 2016
36cfa08
Add comments.
ueshin Mar 7, 2016
0055fd1
Modify test.
ueshin Mar 7, 2016
7ac9648
Merge branch 'master' into issues/SPARK-13640
ueshin Mar 7, 2016
63b1797
Re-modify test.
ueshin Mar 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Synchronize ScalaReflection.mirror method.
  • Loading branch information
@ueshin
ueshin committed Mar 3, 2016
commit 389d644f776504ee335cd26c121dc84c1902cf32
3 changes: 2 additions & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,9 @@ object ScalaReflection extends ScalaReflection {
// Since we are creating a runtime mirror usign the class loader of current thread,
// we need to use def at here. So, every time we call mirror, it is using the
// class loader of the current thread.
override def mirror: universe.Mirror =
override def mirror: universe.Mirror = ScalaReflectionLock.synchronized {
universe.runtimeMirror(Thread.currentThread().getContextClassLoader)
}

import universe._

Expand Down