Skip to content
Closed
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
52ac008
Adding new test suite for [SPARK-12941][SQL]
thomastechs Feb 22, 2016
b711688
Update pom.xml for [SPARK-12941] docker test suite addition
thomastechs Feb 22, 2016
c2c6d14
Update DockerJDBCIntegrationSuite.scala for [SPARK-12941] docker test…
thomastechs Feb 22, 2016
54b2d4e
Update OracleDialect.scala for [SPARK-12941] docker test suite addition
thomastechs Feb 22, 2016
bde06fa
Update OracleIntegrationSuite.scala for [SPARK-12941] docker test sui…
thomastechs Feb 22, 2016
0861d72
Update OracleIntegrationSuite.scala for [SPARK-12941] Style check fix…
thomastechs Feb 23, 2016
ca7ef4e
Update OracleIntegrationSuite.scala for [SPARK-12941] Style check fixes
thomastechs Feb 23, 2016
28a9e9f
Update OracleIntegrationSuite.scala for [SPARK-12941] Style check fixes
thomastechs Feb 23, 2016
87e3d7f
Update pom.xml
thomastechs Feb 23, 2016
7b12418
Update OracleIntegrationSuite.scala
thomastechs Feb 23, 2016
250591d
Update OracleIntegrationSuite.scala
thomastechs Feb 23, 2016
d77d585
Update OracleIntegrationSuite.scala for [SPARK-12941] Style check fixes
thomastechs Feb 23, 2016
7fcb16c
Update OracleIntegrationSuite.scala for [SPARK-12941] Updated Comments
thomastechs Feb 24, 2016
b3de7f4
Update pom.xml for [SPARK-12941] added comments
thomastechs Feb 24, 2016
345555f
Update DockerJDBCIntegrationSuite.scala
thomastechs Feb 24, 2016
3f0f3b8
Updated OracleIntegrationSuite.scala
thomastechs Feb 24, 2016
5683dca
Merge remote-tracking branch 'upstream/master'
thomastechs Mar 3, 2016
3ba7dc5
Update JDBCSuite.scala [SPARK-12941][Master]
thomastechs Mar 3, 2016
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update OracleIntegrationSuite.scala for [SPARK-12941] Style check fixes
Updated style check fixes
  • Loading branch information
thomastechs committed Feb 23, 2016
commit d77d5852b06c4003661757207868c693723210bd
Original file line number Diff line number Diff line change
Expand Up @@ -25,22 +25,22 @@ import org.apache.spark.sql.test.SharedSQLContext
import org.apache.spark.sql.types._
import org.apache.spark.tags.DockerTest
/**
* This integration suite is created as part of Pull request(11306) and is used for the fix
* This integration suite is created as part of Pull request(11306) and is used for the fix
* SPARK-12941, creating a data type mapping to Oracle for the corresponding data type
* "Stringtype" from dataframe. This PR is for the master branch fix, where as another PR
* "Stringtype" from dataframe. This PR is for the master branch fix, where as another PR
* is already tested with the branch 1.4
*
* This patch was tested using the Oracle docker.Created this integration suite for the same.
* The ojdbc6-11.2.0.2.0.jar was to be downloaded from the maven repository.Since there was
* no jdbc jar available in the maven repository, the jar was downloaded from oracle site
* The ojdbc6-11.2.0.2.0.jar was to be downloaded from the maven repository.Since there was
* no jdbc jar available in the maven repository, the jar was downloaded from oracle site
* manually and installed in the local; thus tested. So, for SparkQA test case run, the
* ojdbc jar might be manually placed in the local maven repository(com/oracle/ojdbc6/11.2.0.2.0)
* while Spark QA test run
*
*
* The following would be the steps to test this
* 1. Pull oracle 11g image - docker pull wnameless/oracle-xe-11g
* 2. Start docker - sudo service docker start
* 3. Download oracle 11g driver jar and put it in maven local repo:
* 3. Download oracle 11g driver jar and put it in maven local repo:
* (com/oracle/ojdbc6/11.2.0.2.0/ojdbc6-11.2.0.2.0.jar)
* 4. Run spark test - ./build/sbt "test-only org.apache.spark.sql.jdbc.OracleIntegrationSuite"
*
Expand All @@ -61,7 +61,7 @@ class OracleIntegrationSuite extends DockerJDBCIntegrationSuite with SharedSQLCo

override def dataPreparation(conn: Connection): Unit = {
}

/**
* For SparkQA test case run, the ojdbc6-11.2.0.2.0.jar would be required to be manually
* placed in the local maven repository(com/oracle/ojdbc6/11.2.0.2.0) while Spark QA test
Expand Down