[SPARK-13242] [SQL] codegen fallback in case-when if there many branches #11592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test build #52706 has finished for PR 11592 at commit
|
| object CaseWhen { | ||
|
|
||
| // The maxium number of switches supported with codegen. | ||
| val MAX_NUMBER_OF_SWITCHES = 20 |
Contributor
|
This looks pretty good. Just some minor comments on naming. It'd be great to be more consistent among "branch", "case", and "switch". |
added 2 commits
March 9, 2016 00:17
Contributor
|
LGTM |
|
Test build #52736 has finished for PR 11592 at commit
|
Contributor
Author
|
Merged into master, will create another PR for 1.6 branch |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
## What changes were proposed in this pull request? If there are many branches in a CaseWhen expression, the generated code could go above the 64K limit for single java method, will fail to compile. This PR change it to fallback to interpret mode if there are more than 20 branches. This PR is based on apache#11243 and apache#11221, thanks to joehalliwell Closes apache#11243 Closes apache#11221 ## How was this patch tested? Add a test with 50 branches. Author: Davies Liu <[email protected]> Closes apache#11592 from davies/fix_when.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If there are many branches in a CaseWhen expression, the generated code could go above the 64K limit for single java method, will fail to compile. This PR change it to fallback to interpret mode if there are more than 20 branches.
This PR is based on #11243 and #11221, thanks to @joehalliwell
Closes #11243
Closes #11221
How was this patch tested?
Add a test with 50 branches.