Skip to content

[Spark-13772][SQL] fix data type mismatch for decimal #11605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cenyuhai wants to merge 4 commits into from
Closed

[Spark-13772][SQL] fix data type mismatch for decimal #11605

cenyuhai wants to merge 4 commits into from

Conversation

@cenyuhai
Copy link
Contributor

@cenyuhai cenyuhai commented Mar 9, 2016

fix data type mismatch for decimal, patch for branch 1.6

cloud-fan
cloud-fan reviewed Mar 9, 2016
View reviewed changes
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercionSuite.scala
test("test for SPARK-13772") {
val rule = HiveTypeCoercion.IfCoercion
ruleTest(rule,
If(Literal(true), Literal(1.0), Cast(Literal(1.0), DecimalType(19, 0))),
Copy link
Contributor

@cloud-fan cloud-fan Mar 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also check it with other database systems like Hive? Do they allow double type and decimal type in if and else branches?

Copy link
Contributor Author

@cenyuhai cenyuhai Mar 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cloud-fan It is ok in hive 1.2.1 and spark 1.4.1.
test case:
select if(1=1, cast(1 as double), cast(1 as decimal)) from test

@liancheng
Copy link
Contributor

liancheng commented Mar 17, 2016

ok to test

@liancheng
Copy link
Contributor

liancheng commented Mar 17, 2016

add to whitelist

@SparkQA
Copy link

SparkQA commented Mar 17, 2016

Test build #53421 has finished for PR 11605 at commit 42addd6.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Mar 17, 2016

Test build #53422 has finished for PR 11605 at commit 90cf309.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@liancheng
Copy link
Contributor

liancheng commented Mar 22, 2016

LGTM. Thanks for fixing this! Merging to branch-1.6.

asfgit pushed a commit that referenced this pull request Mar 22, 2016
@cenyuhai @liancheng
[SPARK-13772][SQL] Fix data type mismatch for decimal
3243d46 
Fix data type mismatch for decimal, patch for branch-1.6.

Author: cenyuhai <[email protected]>

Closes #11605 from cenyuhai/SPARK-13772.
@liancheng
Copy link
Contributor

liancheng commented Mar 22, 2016

BTW, next time please use the format like [SPARK-13772][SQL] <Title> in PR title. For this one, I've manually updated the commit message while merging.

@cenyuhai cenyuhai changed the title [Spark-13772] fix data type mismatch for decimal [Spark-13772][SQL] fix data type mismatch for decimal Mar 22, 2016
@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Apr 15, 2016

Hi, @cenyuhai .
If you don't mind, could you close this PR? It's already merged.
Currently, only PRs for master branch seems to close automatically.

@cenyuhai cenyuhai closed this Apr 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cenyuhai @liancheng @SparkQA @dongjoon-hyun @cloud-fan