[SPARK-13817][BUILD][SQL] Re-enable MiMA and removes object DataFrame #11656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #52921 has finished for PR 11656 at commit
|
Contributor
Author
|
Verified that MiMA check had been triggered and passed successfully. |
|
Test build #52923 has finished for PR 11656 at commit
|
Contributor
Author
|
I'm going to merge this to bring MiMA back. |
asfgit
pushed a commit
that referenced
this pull request
Mar 13, 2016
## What changes were proposed in this pull request? SPARK-13817 (PR #11656) replaces `DataFrame` with `Dataset` from Java. This PR fixes the remaining broken links and sample Java code in `package-info.java`. As a result, it will update the following Javadoc. * http://spark.apache.org/docs/latest/api/java/org/apache/spark/ml/attribute/package-summary.html * http://spark.apache.org/docs/latest/api/java/org/apache/spark/ml/feature/package-summary.html ## How was this patch tested? Manual. Author: Dongjoon Hyun <[email protected]> Closes #11675 from dongjoon-hyun/replace_dataframe_with_dataset_in_javadoc.
jeanlyn
pushed a commit
to jeanlyn/spark
that referenced
this pull request
Mar 17, 2016
## What changes were proposed in this pull request? SPARK-13817 (PR apache#11656) replaces `DataFrame` with `Dataset` from Java. This PR fixes the remaining broken links and sample Java code in `package-info.java`. As a result, it will update the following Javadoc. * http://spark.apache.org/docs/latest/api/java/org/apache/spark/ml/attribute/package-summary.html * http://spark.apache.org/docs/latest/api/java/org/apache/spark/ml/feature/package-summary.html ## How was this patch tested? Manual. Author: Dongjoon Hyun <[email protected]> Closes apache#11675 from dongjoon-hyun/replace_dataframe_with_dataset_in_javadoc.
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
## What changes were proposed in this pull request? PR apache#11443 temporarily disabled MiMA check, this PR re-enables it. One extra change is that `object DataFrame` is also removed. The only purpose of introducing `object DataFrame` was to use it as an internal factory for creating `Dataset[Row]`. By replacing this internal factory with `Dataset.newDataFrame`, both `DataFrame` and `DataFrame$` are entirely removed from the API, so that we can simply put a `MissingClassProblem` filter in `MimaExcludes.scala` for most DataFrame API changes. ## How was this patch tested? Tested by MiMA check triggered by Jenkins. Author: Cheng Lian <[email protected]> Closes apache#11656 from liancheng/re-enable-mima.
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
## What changes were proposed in this pull request? SPARK-13817 (PR apache#11656) replaces `DataFrame` with `Dataset` from Java. This PR fixes the remaining broken links and sample Java code in `package-info.java`. As a result, it will update the following Javadoc. * http://spark.apache.org/docs/latest/api/java/org/apache/spark/ml/attribute/package-summary.html * http://spark.apache.org/docs/latest/api/java/org/apache/spark/ml/feature/package-summary.html ## How was this patch tested? Manual. Author: Dongjoon Hyun <[email protected]> Closes apache#11675 from dongjoon-hyun/replace_dataframe_with_dataset_in_javadoc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
PR #11443 temporarily disabled MiMA check, this PR re-enables it.
One extra change is that
object DataFrameis also removed. The only purpose of introducingobject DataFramewas to use it as an internal factory for creatingDataset[Row]. By replacing this internal factory withDataset.newDataFrame, bothDataFrameandDataFrame$are entirely removed from the API, so that we can simply put aMissingClassProblemfilter inMimaExcludes.scalafor most DataFrame API changes.How was this patch tested?
Tested by MiMA check triggered by Jenkins.