Skip to content

[SPARK-13869][SQL] Remove redundant conditions while combining filters #11670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sameeragarwal wants to merge 2 commits into from
Closed

[SPARK-13869][SQL] Remove redundant conditions while combining filters #11670

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c78166d
Remove redundant conditions while combining filters
sameeragarwal Mar 12, 2016
f9aba06
unit tests
sameeragarwal Mar 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove redundant conditions while combining filters
  • Loading branch information
@sameeragarwal
sameeragarwal committed Mar 12, 2016
commit c78166de38f48b11f8e3dc328c95f80451206f7c
11 changes: 7 additions & 4 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -819,12 +819,15 @@ object CombineUnions extends Rule[LogicalPlan] {
}

/**
* Combines two adjacent [[Filter]] operators into one, merging the
* conditions into one conjunctive predicate.
* Combines two adjacent [[Filter]] operators into one, merging the non-redundant conditions into
* one conjunctive predicate.
*/
object CombineFilters extends Rule[LogicalPlan] {
object CombineFilters extends Rule[LogicalPlan] with PredicateHelper {
def apply(plan: LogicalPlan): LogicalPlan = plan transform {
case ff @ Filter(fc, nf @ Filter(nc, grandChild)) => Filter(And(nc, fc), grandChild)
case ff @ Filter(fc, nf @ Filter(nc, grandChild)) =>
val ac = (ExpressionSet(splitConjunctivePredicates(nc)) --
ExpressionSet(splitConjunctivePredicates(fc))).reduce(And)
Filter(And(ac, fc), grandChild)
}
}

Expand Down