Skip to content

[SPARK-13841][SQL] Removes Dataset.collectRows()/takeRows() #11678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
liancheng wants to merge 2 commits into from
Closed

[SPARK-13841][SQL] Removes Dataset.collectRows()/takeRows() #11678

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97a62d6
Removes Dataset.collectRows()/takeRows()
liancheng Mar 12, 2016
e789893
Fixes test failures
liancheng Mar 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixes test failures
  • Loading branch information
@liancheng
liancheng committed Mar 12, 2016
commit e7898939af2a8e839099a4f65b2787d60ee12ea7
2 changes: 1 addition & 1 deletion sql/core/src/test/java/test/org/apache/spark/sql/JavaApplySchemaSuite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ public Row call(Person person) throws Exception {
expected.add(RowFactory.create("Michael", 29));
expected.add(RowFactory.create("Yin", 28));

Assert.assertEquals(expected, Arrays.asList(actual));
Assert.assertEquals(expected, actual);
}

@Test
Expand Down
4 changes: 2 additions & 2 deletions sql/core/src/test/java/test/org/apache/spark/sql/JavaDataFrameSuite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,8 +282,8 @@ public void testSampleBy() {
List<Row> actual = sampled.groupBy("key").count().orderBy("key").collectAsList();
Assert.assertEquals(0, actual.get(0).getLong(0));
Assert.assertTrue(0 <= actual.get(0).getLong(1) && actual.get(0).getLong(1) <= 8);
Assert.assertEquals(1, actual.get(0).getLong(0));
Assert.assertTrue(2 <= actual.get(0).getLong(1) && actual.get(1).getLong(1) <= 13);
Assert.assertEquals(1, actual.get(1).getLong(0));
Assert.assertTrue(2 <= actual.get(1).getLong(1) && actual.get(1).getLong(1) <= 13);
}

@Test
Expand Down