[SPARK-13642][Yarn] Changed the default application exit state to failed for yarn cluster mode #11693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #53062 has finished for PR 11693 at commit
|
| // succeeded in the RM UI. | ||
| // The default state of ApplicationMaster is failed if it is invoked by shut down hook. | ||
| // This behavior is different compared to 1.x version, we guarantee user will not call | ||
| // System.exit() at the end of application, so state will be updated before calling |
Contributor
There was a problem hiding this comment.
I think this comment is a bit confusing. We can't guarantee the user doesn't call System.exit(). I think you mean that spark itself doesn't called it.
Perhaps just remove that and leave the last sentence saying the user shouldn't be calling System.exit(0) on a good shutdown.
Contributor
Author
There was a problem hiding this comment.
Thanks @tgravescs , I will update the comments.
|
Test build #53143 has finished for PR 11693 at commit
|
Contributor
Author
|
Jenkins, retest this please. |
|
Test build #53170 has finished for PR 11693 at commit
|
Contributor
|
LGTM, merging to master. |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
…led for yarn cluster mode ## What changes were proposed in this pull request? Changing the default exit state to `failed` for any application running on yarn cluster mode. ## How was this patch tested? Unit test is done locally. CC tgravescs and vanzin . Author: jerryshao <[email protected]> Closes apache#11693 from jerryshao/SPARK-13642.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Changing the default exit state to
failedfor any application running on yarn cluster mode.How was this patch tested?
Unit test is done locally.
CC @tgravescs and @vanzin .