Skip to content

Conversation

@bjornjon
Copy link
Contributor

What changes were proposed in this pull request?

JavaUtils.java has methods to convert time and byte strings for internal use, this change renames a variable used in byteStringAs(), from timeError to byteError.

@srowen
Copy link
Member

srowen commented Mar 14, 2016

OK, that by itself is probably too minor to bother with. It's not a bad change, but maybe you can look through other similar stretches of code to see if other similar copy / paste errors have been made? it'd be good to try to investigate these in batch as much as possible

@bjornjon
Copy link
Contributor Author

Sounds good. I'll see what I can spot while reading through the code. Whats the best way to review previous suggested changes like this that were to minor to go in? Maybe some of them are still outstanding and I can batch them together.

@srowen
Copy link
Member

srowen commented Mar 14, 2016

I highlighted it just because there have been a few in the past couple days. It's not so much that unrelated tiny changes should be batched together, but that maybe there are other related tiny changes that would be turned up with a search. There may not be, in which case, it's probably OK to merge this.

@bjornjon
Copy link
Contributor Author

Read through all the code in common. No similar oversights, at least not with variable naming.

@andrewor14
Copy link
Contributor

This passed compilation. Merging into master 1.6 1.5

asfgit pushed a commit that referenced this pull request Mar 14, 2016
## What changes were proposed in this pull request?

JavaUtils.java has methods to convert time and byte strings for internal use, this change renames a variable used in byteStringAs(), from timeError to byteError.

Author: Bjorn Jonsson <[email protected]>

Closes #11695 from bjornjon/master.

(cherry picked from commit e06493c)
Signed-off-by: Andrew Or <[email protected]>
@asfgit asfgit closed this in e06493c Mar 14, 2016
asfgit pushed a commit that referenced this pull request Mar 14, 2016
## What changes were proposed in this pull request?

JavaUtils.java has methods to convert time and byte strings for internal use, this change renames a variable used in byteStringAs(), from timeError to byteError.

Author: Bjorn Jonsson <[email protected]>

Closes #11695 from bjornjon/master.

(cherry picked from commit e06493c)
Signed-off-by: Andrew Or <[email protected]>
@SparkQA
Copy link

SparkQA commented Mar 14, 2016

Test build #2633 has finished for PR 11695 at commit 13df574.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Mar 17, 2016
## What changes were proposed in this pull request?

JavaUtils.java has methods to convert time and byte strings for internal use, this change renames a variable used in byteStringAs(), from timeError to byteError.

Author: Bjorn Jonsson <[email protected]>

Closes apache#11695 from bjornjon/master.
roygao94 pushed a commit to roygao94/spark that referenced this pull request Mar 22, 2016
## What changes were proposed in this pull request?

JavaUtils.java has methods to convert time and byte strings for internal use, this change renames a variable used in byteStringAs(), from timeError to byteError.

Author: Bjorn Jonsson <[email protected]>

Closes apache#11695 from bjornjon/master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants