-
Notifications
You must be signed in to change notification settings - Fork 29k
[MINOR][COMMON] Fix copy-paste oversight in variable naming #11695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
OK, that by itself is probably too minor to bother with. It's not a bad change, but maybe you can look through other similar stretches of code to see if other similar copy / paste errors have been made? it'd be good to try to investigate these in batch as much as possible |
|
Sounds good. I'll see what I can spot while reading through the code. Whats the best way to review previous suggested changes like this that were to minor to go in? Maybe some of them are still outstanding and I can batch them together. |
|
I highlighted it just because there have been a few in the past couple days. It's not so much that unrelated tiny changes should be batched together, but that maybe there are other related tiny changes that would be turned up with a search. There may not be, in which case, it's probably OK to merge this. |
|
Read through all the code in common. No similar oversights, at least not with variable naming. |
|
This passed compilation. Merging into master 1.6 1.5 |
## What changes were proposed in this pull request? JavaUtils.java has methods to convert time and byte strings for internal use, this change renames a variable used in byteStringAs(), from timeError to byteError. Author: Bjorn Jonsson <[email protected]> Closes #11695 from bjornjon/master. (cherry picked from commit e06493c) Signed-off-by: Andrew Or <[email protected]>
## What changes were proposed in this pull request? JavaUtils.java has methods to convert time and byte strings for internal use, this change renames a variable used in byteStringAs(), from timeError to byteError. Author: Bjorn Jonsson <[email protected]> Closes #11695 from bjornjon/master. (cherry picked from commit e06493c) Signed-off-by: Andrew Or <[email protected]>
|
Test build #2633 has finished for PR 11695 at commit
|
## What changes were proposed in this pull request? JavaUtils.java has methods to convert time and byte strings for internal use, this change renames a variable used in byteStringAs(), from timeError to byteError. Author: Bjorn Jonsson <[email protected]> Closes apache#11695 from bjornjon/master.
## What changes were proposed in this pull request? JavaUtils.java has methods to convert time and byte strings for internal use, this change renames a variable used in byteStringAs(), from timeError to byteError. Author: Bjorn Jonsson <[email protected]> Closes apache#11695 from bjornjon/master.
What changes were proposed in this pull request?
JavaUtils.java has methods to convert time and byte strings for internal use, this change renames a variable used in byteStringAs(), from timeError to byteError.