[SPARK-13870][SQL] Add scalastyle escaping correctly in CVSSuite.scala #11700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #53093 has finished for PR 11700 at commit
|
Contributor
|
retest this please |
|
Test build #53114 has finished for PR 11700 at commit
|
Member
Author
|
Thank you, @andrewor14 . |
Member
Author
|
Just rebased. |
|
Test build #53128 has finished for PR 11700 at commit
|
Member
Author
|
Finally! @andrewor14 Could you merge this, please? |
Contributor
|
Merging in master. Thanks. |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
## What changes were proposed in this pull request?
When initial creating `CVSSuite.scala` in SPARK-12833, there was a typo on `scalastyle:on`: `scalstyle:on`. So, it turns off ScalaStyle checking for the rest of the file mistakenly. So, it can not find a violation on the code of `SPARK-12668` added recently. This issue fixes the existing escaping correctly and adds a new escaping for `SPARK-12668` code like the following.
```scala
test("test aliases sep and encoding for delimiter and charset") {
+ // scalastyle:off
val cars = sqlContext
...
.load(testFile(carsFile8859))
+ // scalastyle:on
```
This will prevent future potential problems, too.
## How was this patch tested?
Pass the Jenkins test.
Author: Dongjoon Hyun <[email protected]>
Closes apache#11700 from dongjoon-hyun/SPARK-13870.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When initial creating
CVSSuite.scalain SPARK-12833, there was a typo onscalastyle:on:scalstyle:on. So, it turns off ScalaStyle checking for the rest of the file mistakenly. So, it can not find a violation on the code ofSPARK-12668added recently. This issue fixes the existing escaping correctly and adds a new escaping forSPARK-12668code like the following.This will prevent future potential problems, too.
How was this patch tested?
Pass the Jenkins test.