Skip to content

[SPARK-13808][test-maven] Don't build assembly in dev/run-tests #11701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoshRosen wants to merge 7 commits into from
Closed

[SPARK-13808][test-maven] Don't build assembly in dev/run-tests #11701

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2c10193
Remove assembly in tests.
JoshRosen Mar 14, 2016
267aaf9
Fix ClassNotFoundException errors in PySpark streaming tests.
JoshRosen Mar 14, 2016
e6e3c20
Revert "Fix ClassNotFoundException errors in PySpark streaming tests."
JoshRosen Mar 14, 2016
1154eb4
Remove external/ projects from SPARK_PREPEND_CLASSES
JoshRosen Mar 14, 2016
1fd489c
Enable Hive in PySpark test deps.
JoshRosen Mar 15, 2016
20d2e2a
Tolerate missing SPARK_JARS_DIR in tests.
JoshRosen Mar 16, 2016
0900b13
Continue to build assembly in Maven tests (for now)
JoshRosen Mar 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tolerate missing SPARK_JARS_DIR in tests.
  • Loading branch information
@JoshRosen
JoshRosen committed Mar 16, 2016
commit 20d2e2a864ce7b4696a600bd5f68dafe6357c537
6 changes: 3 additions & 3 deletions bin/spark-class
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,14 @@ else
SPARK_JARS_DIR="${SPARK_HOME}/assembly/target/scala-$SPARK_SCALA_VERSION"
fi

if [ ! -d "$SPARK_JARS_DIR" ]; then
if [ ! -d "$SPARK_JARS_DIR" ] && [ -z "$SPARK_TESTING" ]; then
echo "Failed to find Spark jars directory ($SPARK_JARS_DIR)." 1>&2
echo "You need to build Spark before running this program." 1>&2
exit 1
else
LAUNCH_CLASSPATH="$SPARK_JARS_DIR/*"
fi

LAUNCH_CLASSPATH="$SPARK_JARS_DIR/*"

# Add the launcher build dir to the classpath if requested.
if [ -n "$SPARK_PREPEND_CLASSES" ]; then
LAUNCH_CLASSPATH="${SPARK_HOME}/launcher/target/scala-$SPARK_SCALA_VERSION/classes:$LAUNCH_CLASSPATH"
Copy link
Contributor

@vanzin vanzin Mar 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow this is not being picked up (test is failing because the Main class is not found). Is this path correct for maven too?

Expand Down