Skip to content

[SPARK-13921] Store serialized blocks as multiple chunks in MemoryStore #11748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoshRosen wants to merge 20 commits into from
Closed

[SPARK-13921] Store serialized blocks as multiple chunks in MemoryStore #11748

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
735eca6
Split MemoryEntry into two separate classes (serialized and deseriali…
JoshRosen Mar 15, 2016
8f08289
Add ChunkedByteBuffer and use it in storage layer.
JoshRosen Mar 15, 2016
79b1a6a
Add test cases and fix bug in ChunkedByteBuffer.toInputStream()
JoshRosen Mar 15, 2016
7dbcd5a
WIP towards understanding destruction.
JoshRosen Mar 15, 2016
3fbec21
Small fixes to dispose behavior.
JoshRosen Mar 15, 2016
e5e663f
Modify BlockManager.dataSerialize to write ChunkedByteBuffers.
JoshRosen Mar 15, 2016
de62f0d
Merge remote-tracking branch 'origin/master' into chunked-block-seria…
JoshRosen Mar 16, 2016
0a347fd
Fix test compilation in streaming.
JoshRosen Mar 16, 2016
6852c48
Merge remote-tracking branch 'origin/master' into chunked-block-seria…
JoshRosen Mar 16, 2016
43f8fa6
Allow ChunkedByteBuffer to contain no chunks.
JoshRosen Mar 16, 2016
25e6884
Document toByteBuffer() and toArray() size limitations.
JoshRosen Mar 16, 2016
325c83d
Move dispose() from BlockManager to StorageUtils.
JoshRosen Mar 16, 2016
4f5074e
Better documentation for dispose() methods.
JoshRosen Mar 16, 2016
b6ddf3e
Rename limit to size.
JoshRosen Mar 16, 2016
719ad3c
Implement missing InputStream methods.
JoshRosen Mar 16, 2016
2300607
More comments.
JoshRosen Mar 16, 2016
3fc0b66
Fix confusing getChunks().head
JoshRosen Mar 16, 2016
c747c85
Merge remote-tracking branch 'origin/master' into chunked-block-seria…
JoshRosen Mar 17, 2016
cb9311b
Fix logging import.
JoshRosen Mar 17, 2016
2970932
Clean up dispose logic to address review comments.
JoshRosen Mar 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test compilation in streaming.
  • Loading branch information
@JoshRosen
JoshRosen committed Mar 16, 2016
commit 0a347fdd9ec0e94eab17eb0f33c93acd1afbdcfb
2 changes: 1 addition & 1 deletion streaming/src/test/scala/org/apache/spark/streaming/ReceivedBlockHandlerSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ class ReceivedBlockHandlerSuite

storeAndVerify(blocks.map { b => IteratorBlock(b.toIterator) })
storeAndVerify(blocks.map { b => ArrayBufferBlock(new ArrayBuffer ++= b) })
storeAndVerify(blocks.map { b => ByteBufferBlock(dataToByteBuffer(b)) })
storeAndVerify(blocks.map { b => ByteBufferBlock(dataToByteBuffer(b).toByteBuffer) })
}

/** Test error handling when blocks that cannot be stored */
Expand Down
2 changes: 1 addition & 1 deletion ...ming/src/test/scala/org/apache/spark/streaming/rdd/WriteAheadLogBackedBlockRDDSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ class WriteAheadLogBackedBlockRDDSuite
require(blockData.size === blockIds.size)
val writer = new FileBasedWriteAheadLogWriter(new File(dir, "logFile").toString, hadoopConf)
val segments = blockData.zip(blockIds).map { case (data, id) =>
writer.write(blockManager.dataSerialize(id, data.iterator))
writer.write(blockManager.dataSerialize(id, data.iterator).toByteBuffer)
}
writer.close()
segments
Expand Down