Skip to content

[Minor][DOC] Fix nits in JavaStreamingTestExample #11821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhengruifeng wants to merge 3 commits into from
Closed

[Minor][DOC] Fix nits in JavaStreamingTestExample #11821

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dcce428
create je_fix
zhengruifeng Mar 18, 2016
09ad928
del throws
zhengruifeng Mar 18, 2016
9a16f30
del space
zhengruifeng Mar 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
del throws
  • Loading branch information
@zhengruifeng
zhengruifeng committed Mar 18, 2016
commit 09ad928e3f5efde847eae324b648bfed227c0f34
6 changes: 3 additions & 3 deletions examples/src/main/java/org/apache/spark/examples/mllib/JavaStreamingTestExample.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public static void main(String[] args) {
JavaDStream<BinarySample> data = ssc.textFileStream(dataDir).map(
new Function<String, BinarySample>() {
@Override
public BinarySample call(String line) throws Exception {
public BinarySample call(String line) {
String[] ts = line.split(",");
boolean label = Boolean.valueOf(ts[0]);
double value = Double.valueOf(ts[1]);
Expand All @@ -101,12 +101,12 @@ public BinarySample call(String line) throws Exception {

out.foreachRDD(new VoidFunction<JavaRDD<StreamingTestResult>>() {
@Override
public void call(JavaRDD<StreamingTestResult> rdd) throws Exception {
public void call(JavaRDD<StreamingTestResult> rdd) {
timeoutCounter -= 1;

boolean anySignificant = ! rdd.filter(new Function<StreamingTestResult, Boolean>() {
Copy link
Member

@srowen srowen Mar 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(No space after "!")
Looking good, thank you for indulging. The example is now about as close as possible to the scala version

Copy link
Contributor Author

@zhengruifeng zhengruifeng Mar 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, the space is removed.

@Override
public Boolean call(StreamingTestResult v) throws Exception {
public Boolean call(StreamingTestResult v) {
return v.pValue() < 0.05;
}
}).isEmpty();
Expand Down