Skip to content

[SQL]Extract the joinkeys from join condition #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chenghao-intel wants to merge 4 commits into from
Closed

[SQL]Extract the joinkeys from join condition #1190

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dcc4584
Extract the joinkeys from join condition
chenghao-intel Jun 24, 2014
cec34e8
Update the code style issues
chenghao-intel Jun 24, 2014
ceb4924
Remove the redundant pattern of join keys extraction
chenghao-intel Jun 26, 2014
4a1060a
Fix some of the small issues
chenghao-intel Jun 27, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update the code style issues
  • Loading branch information
@chenghao-intel
chenghao-intel committed Jun 26, 2014
commit cec34e883d8be966321059b9974e10fcedeed8e8
6 changes: 3 additions & 3 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,8 @@ object ExtractEquiJoinKeys extends Logging with PredicateHelper {
logger.debug(s"Considering join on: $condition")
// Find equi-join predicates that can be evaluated before the join, and thus can be used
// as join keys.
val (joinPredicates, otherPredicates) = condition.map(splitConjunctivePredicates).
getOrElse(Nil).partition {
val (joinPredicates, otherPredicates) =
condition.map(splitConjunctivePredicates).getOrElse(Nil).partition {
case EqualTo(l, r) if (canEvaluate(l, left) && canEvaluate(r, right)) ||
(canEvaluate(l, right) && canEvaluate(r, left)) => true
case _ => false
Expand All @@ -186,7 +186,7 @@ object ExtractEquiJoinKeys extends Logging with PredicateHelper {
val leftKeys = joinKeys.map(_._1)
val rightKeys = joinKeys.map(_._2)

if(leftKeys.length > 0) {
if (leftKeys.length > 0) {
logger.debug(s"leftKeys:${leftKeys} | rightKeys:${rightKeys}")
Some((joinType, leftKeys, rightKeys, otherPredicates.reduceOption(And), left, right))
} else {
Expand Down