[SPARK-14147] [ML] [SparkR] SparkR predict should not output feature column #11958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #54166 has finished for PR 11958 at commit
|
Contributor
|
Thanks, @yanboliang , this will solve the problem. It seems that the changeset includes only naive bayes and survival analysis. Can we also do the changes for kmeans and glm ? Thanks! |
Contributor
Author
|
@NarineK I think we will make SparkRWrapper refactor for glm and kmeans soon, it's simpler to do the changes after the refactor. Thanks! |
|
Test build #55610 has finished for PR 11958 at commit
|
Contributor
|
LGTM. Merged into master. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SparkR does not support type of vector which is the default type of feature column in ML. R predict also does not output intermediate feature column. So SparkR
predictshould not output feature column. In this PR, I only fix this issue fornaiveBayesandsurvreg.kmeanshas the right code route already andglmwill be fixed at SparkRWrapper refactor(#12294).How was this patch tested?
No new tests.
cc @mengxr @shivaram