[SPARK-12740] [SPARK-13932] support grouping()/grouping_id() in having/order clause #12235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @cloud-fan |
| } | ||
| } | ||
|
|
||
| private def isAggregateExpression(e: Expression): Boolean = { |
Contributor
There was a problem hiding this comment.
do you need this method anymore? It's just a simple isInstanceOf now
Contributor
|
overall LGTM |
|
Test build #55201 has finished for PR 12235 at commit
|
Contributor
Author
|
@marmbrus Could you also take a quick look on this one? |
davies
changed the title
|
Test build #55229 has finished for PR 12235 at commit
|
| val groupingIdName: String = "grouping__id" | ||
| // The attribute name used by Hive, which has different result than Spark, deprecated. | ||
| val hiveGroupingIdName: String = "grouping__id" | ||
| val groupingIdName: String = "spark_grouping_id" |
Contributor
There was a problem hiding this comment.
Can you explain what's going on here?
Contributor
Author
There was a problem hiding this comment.
"grouping__id" came from Hive, but unfortunately the implementation is wrong, see https://issues.apache.org/jira/browse/HIVE-12833. So we deprecated to favor the standard function grouping_id() as public API. "spark_grouping_id" is the virtual column only used internally.
Contributor
|
LGTM |
Contributor
Author
|
Merged into master, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR brings the support of using grouping()/grouping_id() in HAVING/ORDER BY clause.
The resolved grouping()/grouping_id() will be replaced by unresolved "spark_gropuing_id" virtual attribute, then resolved by ResolveMissingAttribute.
This PR also fix the HAVING clause that access a grouping column that is not presented in SELECT clause, for example:
How was this patch tested?
Add new tests.