Skip to content

[Spark-14564] [ML] [MLlib] [PySpark] Python Word2Vec missing setWindowSize method #12428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasoncl wants to merge 8 commits into from
Closed

[Spark-14564] [ML] [MLlib] [PySpark] Python Word2Vec missing setWindowSize method #12428

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1d9ac29
added windowSize setter and getter for python word2Vec
jasoncl Apr 12, 2016
1e373aa
added windowSize test case
jasoncl Apr 14, 2016
859dd1b
added windowSize test case
jasoncl Apr 14, 2016
2f757c8
added assertEqual for windowSize test case
jasoncl Apr 14, 2016
2614fe8
set correct version
jasoncl Apr 14, 2016
83bbdc1
added a test case in ml
jasoncl Apr 14, 2016
417a7d4
rephrase doc for windowSize
jasoncl Apr 15, 2016
5cdcf22
changes made based on review comments
jasoncl Apr 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
changes made based on review comments
  • Loading branch information
@jasoncl
jasoncl committed Apr 18, 2016
commit 5cdcf22cf0090e3f58b5f1b19c18c350cd6e2d5c
4 changes: 2 additions & 2 deletions python/pyspark/ml/feature.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2174,7 +2174,7 @@ class Word2Vec(JavaEstimator, HasStepSize, HasMaxIter, HasSeed, HasInputCol, Has
"the minimum number of times a token must appear to be included in the " +
"word2vec model's vocabulary", typeConverter=TypeConverters.toInt)
windowSize = Param(Params._dummy(), "windowSize",
"the window size (context words from [-window, window])",
"the window size (context words from [-window, window]). Default value is 5",
typeConverter=TypeConverters.toInt)

@keyword_only
Expand Down Expand Up @@ -2253,7 +2253,7 @@ def setWindowSize(self, value):
"""
Sets the value of :py:attr:`windowSize`.
"""
self._paramMap[self.windowSize] = value
self._set(windowSize=value)
return self

@since("2.0.0")
Expand Down
3 changes: 1 addition & 2 deletions python/pyspark/ml/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,8 +340,7 @@ def test_param_property_error(self):
self.assertEqual(len(params), 1)

def test_word2vec_param(self):
model = Word2Vec() \
.setWindowSize(6)
model = Word2Vec().setWindowSize(6)
# Check windowSize is set properly
self.assertEqual(model.getWindowSize(), 6)

Expand Down