-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-14739][Python] Fix for Sparse and Dense Vector Parsing Errors #12513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
#1 from zero323/patch-1 Fix pre-existing parsing tests
|
duplicate to #12516. |
|
#12516 Has not Fixed the Incorrect Test cases and has only added his test case to the existing They have been comparing the parsing the values using assertTrue instead of assertEquals. |
|
EDIT: I encountered these out of order. Actually, I'd be happy to see the first of these two merged that fixes all the issues. Go ahead here. Really the other PR came second |
|
@srowen I've tested both the PR and both have the issue Fixed the only difference is the test case I've mentioned earlier which is already patched in this request. |
|
Jenkins test this please |
|
Test build #56351 has finished for PR 12513 at commit
|
|
Looks pretty good to me based on my understanding of the issue |
|
EDIT again: OK, see discussion on #12516 about why maybe that's fairer to merge |
|
Thank you @vishnu667 for the assist, you can close this PR. |
What changes were proposed in this pull request?
Fixed parsing empty dense and sparse vectors, corrected dead parsing tests.
How was this patch tested?
Fixed parsing tests, added tests specific to SPARK-14739