Skip to content

Conversation

@vishnu667
Copy link

What changes were proposed in this pull request?

Fixed parsing empty dense and sparse vectors, corrected dead parsing tests.

How was this patch tested?

Fixed parsing tests, added tests specific to SPARK-14739

@viirya
Copy link
Member

viirya commented Apr 20, 2016

duplicate to #12516.

@vishnu667
Copy link
Author

@viirya @srowen

#12516 Has not Fixed the Incorrect Test cases and has only added his test case to the existing

They have been comparing the parsing the values using assertTrue instead of assertEquals.
Fix for the Existing previous test cases

@srowen
Copy link
Member

srowen commented Apr 20, 2016

EDIT: I encountered these out of order. Actually, I'd be happy to see the first of these two merged that fixes all the issues. Go ahead here. Really the other PR came second

@vishnu667
Copy link
Author

@srowen I've tested both the PR and both have the issue Fixed the only difference is the test case I've mentioned earlier which is already patched in this request.

@srowen
Copy link
Member

srowen commented Apr 20, 2016

Jenkins test this please

@SparkQA
Copy link

SparkQA commented Apr 20, 2016

Test build #56351 has finished for PR 12513 at commit e63b6b2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Apr 20, 2016

Looks pretty good to me based on my understanding of the issue

@arashpa
Copy link

arashpa commented Apr 20, 2016

@srowen I had another PR #12510 coming in first but made a mistake by closing it. I'm also the original person who found the bug and created the first solution for it. Please if possible consider #12516 as the candidate solution.

@srowen
Copy link
Member

srowen commented Apr 20, 2016

EDIT again: OK, see discussion on #12516 about why maybe that's fairer to merge

@srowen
Copy link
Member

srowen commented Apr 21, 2016

Thank you @vishnu667 for the assist, you can close this PR.

@vishnu667
Copy link
Author

#12516

@vishnu667 vishnu667 closed this Apr 21, 2016
@vishnu667 vishnu667 deleted the SPARK-14739 branch April 21, 2016 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants