Skip to content

[Minor] [ML] [PySpark] Fix omissive param setters which should use _set method #12531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yanboliang wants to merge 1 commit into from
Closed

[Minor] [ML] [PySpark] Fix omissive param setters which should use _set method #12531

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix omissive param setters which should use _set method
  • Loading branch information
@yanboliang
yanboliang committed Apr 20, 2016
commit 864b9b0c06f2b593a4619830642eff828e2c4f65
4 changes: 2 additions & 2 deletions python/pyspark/ml/feature.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ def setBinary(self, value):
"""
Sets the value of :py:attr:`binary`.
"""
self._paramMap[self.binary] = value
self._set(binary=value)
return self

@since("2.0.0")
Expand Down Expand Up @@ -569,7 +569,7 @@ def setBinary(self, value):
"""
Sets the value of :py:attr:`binary`.
"""
self._paramMap[self.binary] = value
self._set(binary=value)
return self

@since("2.0.0")
Expand Down