[SPARK-14757][SQL] Corrected doGenCode() in EqualNullSafe predicate #12628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Contributor
|
can you add a test case? |
rxin
added a commit
to rxin/spark
that referenced
this pull request
Apr 30, 2016
…rection [SPARK-14757][SQL] Corrected doGenCode() in EqualNullSafe predicate
Contributor
|
I did it here: #12799 |
asfgit
pushed a commit
that referenced
this pull request
Apr 30, 2016
This patch fixes a null handling bug in EqualNullSafe's code generation. Updated unit test so they would fail without the fix. Closes #12628. Author: Reynold Xin <[email protected]> Author: Arash Nabili <[email protected]> Closes #12799 from rxin/equalnullsafe.
zzcclp
pushed a commit
to zzcclp/spark
that referenced
this pull request
May 3, 2016
This patch fixes a null handling bug in EqualNullSafe's code generation. Updated unit test so they would fail without the fix. Closes apache#12628. Author: Reynold Xin <[email protected]> Author: Arash Nabili <[email protected]> Closes apache#12799 from rxin/equalnullsafe. (cherry picked from commit 10d513f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the doGenCode() function for the EqualNullSafe predicate, in determining whether the two operands are equal, check that the right operand is not null, in addition to checking the left operand. This is because if only one of the operands is null, then the two operands are guaranteed not to be equal. Therefore, in order to have a valid comparison using
==, both operands have to be non-null.How was this patch tested?
This patch was tested using the example given in the JIRA for this issue.