rename

mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala

@@ -219,18 +219,18 @@ private[spark] class MatrixUDT extends UserDefinedType[Matrix] {
         val numRows = row.getInt(1)
         val numCols = row.getInt(2)
         val values = row.getArray(5) match {
-          case u: UnsafeArrayData => u.toPrimitiveDoubleArray
+          case u: UnsafeArrayData => u.toDoubleArrayUnchecked
           case a => a.toDoubleArray()
         }
         val isTransposed = row.getBoolean(6)
         tpe match {
           case 0 =>
             val colPtrs = row.getArray(3) match {
-              case u: UnsafeArrayData => u.toPrimitiveIntArray
+              case u: UnsafeArrayData => u.toIntArrayUnchecked
               case a => a.toIntArray()
             }
             val rowIndices = row.getArray(4) match {
-              case u: UnsafeArrayData => u.toPrimitiveIntArray
+              case u: UnsafeArrayData => u.toIntArrayUnchecked
               case a => a.toIntArray()
             }
             new SparseMatrix(numRows, numCols, colPtrs, rowIndices, values, isTransposed)

mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala

@@ -238,17 +238,17 @@ class VectorUDT extends UserDefinedType[Vector] {
           case 0 =>
             val size = row.getInt(1)
             val indices = row.getArray(2) match {
-              case u: UnsafeArrayData => u.toPrimitiveIntArray
+              case u: UnsafeArrayData => u.toIntArrayUnchecked
               case a => a.toIntArray()
             }
             val values = row.getArray(3) match {
-              case u: UnsafeArrayData => u.toPrimitiveDoubleArray
+              case u: UnsafeArrayData => u.toDoubleArrayUnchecked
               case a => a.toDoubleArray()
             }
             new SparseVector(size, indices, values)
           case 1 =>
             val values = row.getArray(3) match {
-              case u: UnsafeArrayData => u.toPrimitiveDoubleArray
+              case u: UnsafeArrayData => u.toDoubleArrayUnchecked
               case a => a.toDoubleArray()
             }
             new DenseVector(values)

sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java

@@ -337,14 +337,24 @@ public UnsafeArrayData copy() {
     return arrayCopy;
   }
 
-  public int[] toPrimitiveIntArray() {
+  /**
+   * A faster version of `toIntArray`, which use memory copy instead of iterating all elements.
+   * Note that, this method is dangerous if this array contains null elements.  We don't write
+   * null elements into the data region and memory copy will crash as the data size doesn't match.
+   */
+  public int[] toIntArrayUnchecked() {
     int[] result = new int[numElements];
     Platform.copyMemory(baseObject, baseOffset + 4 + 4L * numElements,
       result, Platform.INT_ARRAY_OFFSET, 4L * numElements);
     return result;
   }
 
-  public double[] toPrimitiveDoubleArray() {
+  /**
+   * A faster version of `toDoubleArray`, which use memory copy instead of iterating all elements.
+   * Note that, this method is dangerous if this array contains null elements.  We don't write
+   * null elements into the data region and memory copy will crash as the data size doesn't match.
+   */
+  public double[] toDoubleArrayUnchecked() {
     double[] result = new double[numElements];
     Platform.copyMemory(baseObject, baseOffset + 4 + 4L * numElements,
       result, Platform.DOUBLE_ARRAY_OFFSET, 8L * numElements);

sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/UnsafeArraySuite.scala

@@ -42,17 +42,17 @@ class UnsafeArraySuite extends SparkFunSuite {
     assert(unsafe.getDouble(2) == 3.3)
   }
 
-  test("to primitive int array") {
+  test("to int array unchecked") {
     val array = Array(1, 10, 100)
     val unsafe = UnsafeArrayData.fromPrimitiveArray(array)
-    val array2 = unsafe.toPrimitiveIntArray
+    val array2 = unsafe.toIntArrayUnchecked
     assert(array.toSeq == array2.toSeq)
   }
 
-  test("to primitive double array") {
+  test("to double array unchecked") {
     val array = Array(1.1, 2.2, 3.3)
     val unsafe = UnsafeArrayData.fromPrimitiveArray(array)
-    val array2 = unsafe.toPrimitiveDoubleArray
+    val array2 = unsafe.toDoubleArrayUnchecked
     assert(array.toSeq == array2.toSeq)
   }
 }