Skip to content

[SPARK-12660] [SPARK-14967] [SQL] Implement Except Distinct by Left Anti Join #12736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gatorsmile wants to merge 10 commits into from
Closed

[SPARK-12660] [SPARK-14967] [SQL] Implement Except Distinct by Left Anti Join #12736

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cd6b684
initial fix
gatorsmile Apr 27, 2016
43e7436
added a test case.
gatorsmile Apr 27, 2016
89fae2a
antiJoin fix from Herman
gatorsmile Apr 27, 2016
8397f22
added test cases
gatorsmile Apr 27, 2016
a104f99
Merge remote-tracking branch 'upstream/master' into exceptByAntiJoin
gatorsmile Apr 27, 2016
f825dca
style fix.
gatorsmile Apr 27, 2016
70da501
fixed the test case.
gatorsmile Apr 27, 2016
3c61a5a
Merge remote-tracking branch 'upstream/master' into exceptByAntiJoin
gatorsmile Apr 27, 2016
7ccd95b
one more test case
gatorsmile Apr 27, 2016
4920360
address comments
gatorsmile Apr 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
one more test case
  • Loading branch information
@gatorsmile
gatorsmile committed Apr 27, 2016
commit 7ccd95bde462e6e5cba93f3923df77843734425c
10 changes: 10 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,16 @@ class DataFrameSuite extends QueryTest with SharedSQLContext {
Nil)
}

test("except distinct - SQL compliance") {
val df_left = Seq(1, 2, 2, 3, 3, 4).toDF("id")
val df_right = Seq(1, 3).toDF("id")

checkAnswer(
df_left.except(df_right),
Row(2) :: Row(4) :: Nil
)
}

test("except - nullability") {
val nonNullableInts = Seq(Tuple1(11), Tuple1(3)).toDF()
assert(nonNullableInts.schema.forall(_.nullable == false))
Copy link
Contributor

@cloud-fan cloud-fan Apr 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: forall(!_.nullable)

Copy link
Member Author

@gatorsmile gatorsmile Apr 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do. Thanks!

Expand Down