-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-15162][SPARK-15164][PySpark][DOCS][ML] update some pydocs #12938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
holdenk
wants to merge
34
commits into
apache:master
from
holdenk:SPARK-15162-SPARK-15164-update-some-pydocs
Closed
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
8389280
Mark a number of alogrithms and models experimental that are marked t…
holdenk 1fa57e5
Add the rest
holdenk b1ce817
Use mathjax for formula in PyDoc
holdenk 8125c8c
Switch to math highlighting and update legostic regresion get doc sin…
holdenk c72fa46
Long line fix
holdenk 3fd1dce
Start adding the missing params to mutli-layer perceptron, also inves…
holdenk c7caa43
Or wait we just don't need to support None
holdenk 4776221
Update the doc string for weights param and add doctest that verifys …
holdenk 64942b7
Merge in master
holdenk 2397004
mini fix
holdenk 130d05f
Merge branch 'master' into SPARK-15162-SPARK-15164-update-some-pydocs
holdenk a73913b
more pydoc fix
holdenk 50b41ae
Merge branch 'master' into SPARK-15162-SPARK-15164-update-some-pydocs
holdenk 9e38ddf
Remove flaky doctet component
holdenk f4df8f0
Add a : as requested
holdenk 5df5a93
Merge in master
holdenk 2eec947
Back out some unrelated changes that are in a seperate PR anyways
holdenk e11dbf8
Merge branch 'master' into SPARK-15162-SPARK-15164-update-some-pydocs
holdenk 4111b2d
Update scaladoc and PyDoc to both have the correct chain for getThres…
holdenk 53ab790
pep8
holdenk c2c7900
Merge branch 'master' into SPARK-15162-SPARK-15164-update-some-pydocs
holdenk a7aadec
Revert doc change
holdenk e4061f4
minor fix
holdenk 7b634b6
Merge branch 'master' into SPARK-15162-SPARK-15164-update-some-pydocs
holdenk 873f6c8
Merge branch 'master' into SPARK-15162-SPARK-15164-update-some-pydocs
holdenk 9fb2e41
Merge branch 'master' into SPARK-15162-SPARK-15164-update-some-pydocs
holdenk 74636b1
Merge branch 'master' into SPARK-15162-SPARK-15164-update-some-pydocs
holdenk d925f38
Merge branch 'master' into SPARK-15162-SPARK-15164-update-some-pydocs
holdenk 3981612
oook lets try 86ing mathjax but... welll w/e
holdenk 3d13c6c
reenable mathjax
holdenk 2be8cdf
Revert "[SPARK-15745][SQL] Use classloader's getResource() for readin…
holdenk 4431daa
Support both methods
holdenk d842309
Revert "Support both methods"
holdenk de63f9f
Revert "Revert "[SPARK-15745][SQL] Use classloader's getResource() fo…
holdenk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update scaladoc and PyDoc to both have the correct chain for getThres…
…hold (thresholds -> threshold -> threshold default value)
- Loading branch information
commit 4111b2d01c33fac3c2537fe9430ce05063530a48
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -99,7 +99,7 @@ class LogisticRegression(JavaEstimator, HasFeaturesCol, HasLabelCol, HasPredicti | |
| threshold = Param(Params._dummy(), "threshold", | ||
| "Threshold in binary classification prediction, in range [0, 1]." + | ||
| " If threshold and thresholds are both set, they must match." + | ||
| "e.g. threshold must be equal to [1-p, p].", | ||
| "e.g. if threshold is p, then thresholds must be equal to [1-p, p].", | ||
| typeConverter=TypeConverters.toFloat) | ||
|
|
||
| @keyword_only | ||
|
|
@@ -157,10 +157,11 @@ def setThreshold(self, value): | |
| @since("1.4.0") | ||
| def getThreshold(self): | ||
| """ | ||
| Gets the value of threshold or attempt to convert thresholds to threshold if set, or default | ||
| value if neither are set. | ||
| This conversion is equivalent to: | ||
| :math:`\\frac{1}{1 + \\frac{thresholds(0)}{thresholds(1)}}`. | ||
| Get threshold for binary classification. | ||
|
|
||
| If :py:attr:`thresholds is set with length 2 (i.e., binary classification), | ||
| this returns the equivalent threshold: :math:`\\frac{1}{1 + \\frac{thresholds(0)}{thresholds(1)}}`. | ||
| Otherwise, returns :py:attr:`threshold` if set or its default value. | ||
|
||
| """ | ||
| self._checkThresholdConsistency() | ||
| if self.isSet(self.thresholds): | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing ` here