[SPARK-15547][SQL] nested case class in encoder can have different number of fields from the real schema #13474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test build #59879 has finished for PR 13474 at commit
|
Contributor
|
LGTM, but shall we merge #13269 first? |
Contributor
|
Let's wait for #13269 first. |
Contributor
|
LGTM pending Jenkins. |
|
Test build #59943 has finished for PR 13474 at commit
|
Contributor
|
Merging to master and branch-2.0. |
Contributor
|
Was this merged into 2.0? |
Contributor
|
Looks like it's not. I'm going to merge it in 2.0. |
asfgit
pushed a commit
that referenced
this pull request
Jun 16, 2016
…mber of fields from the real schema There are 2 kinds of `GetStructField`: 1. resolved from `UnresolvedExtractValue`, and it will have a `name` property. 2. created when we build deserializer expression for nested tuple, no `name` property. When we want to validate the ordinals of nested tuple, we should only catch `GetStructField` without the name property. new test in `EncoderResolutionSuite` Author: Wenchen Fan <[email protected]> Closes #13474 from cloud-fan/ordinal-check. (cherry picked from commit 61b80d5) Signed-off-by: Reynold Xin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There are 2 kinds of
GetStructField:UnresolvedExtractValue, and it will have anameproperty.nameproperty.When we want to validate the ordinals of nested tuple, we should only catch
GetStructFieldwithout the name property.How was this patch tested?
new test in
EncoderResolutionSuite