[SPARK-14926] [ML] OneVsRest labelMetadata uses incorrect name #13762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@josh-howes Did you try compiling the code? |
Member
|
Ping |
|
Test build #3251 has finished for PR 13762 at commit
|
josh-howes
force-pushed
the
Bugfix/SPARK-14926-One_vs_Rest-labelMetadata
branch
from
bd510ec to
b4badae
Compare
Contributor
Author
|
@SparkQA build |
Member
|
I think we should close this PR. |
Contributor
Author
|
I recently pushed a change to this but @SparkQA didn't kick off an automated build. Is that because I squashed my commits? |
Member
|
Jenkins test this please |
|
Test build #65256 has finished for PR 13762 at commit
|
jkbradley
reviewed
Oct 7, 2016
Member
jkbradley
left a comment
jkbradley
left a comment
There was a problem hiding this comment.
Also, could you please add a line to a unit test to verify that the predictionCol has the correct metadata? Thank you!
| // output label and label metadata as prediction | ||
| val predictionMetadata = new MetadataBuilder() | ||
| .withMetadata(labelMetadata) | ||
| .putString("name", predictionCol.name) |
Member
There was a problem hiding this comment.
This should go through the standard ML attribute constructors to modify labelMetadata:
val predictionMetadata = Attribute.fromMetadata(labelMetadata)
.withName($(predictionCol))
.toMetadata()
|
Test build #3299 has finished for PR 13762 at commit
|
Member
|
Hi @josh-howes is it still active? If so, please address the comments above. Otherwise, I would rather like to propose to close this. |
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 22, 2025
## What changes were proposed in this pull request? This PR proposes to close PRs ... - inactive to the review comments more than a month - WIP and inactive more than a month - with Jenkins build failure but inactive more than a month - suggested to be closed and no comment against that - obviously looking inappropriate (e.g., Branch 0.5) To make sure, I left a comment for each PR about a week ago and I could not have a response back from the author in these PRs below: Closes apache#11129 Closes apache#12085 Closes apache#12162 Closes apache#12419 Closes apache#12420 Closes apache#12491 Closes apache#13762 Closes apache#13837 Closes apache#13851 Closes apache#13881 Closes apache#13891 Closes apache#13959 Closes apache#14091 Closes apache#14481 Closes apache#14547 Closes apache#14557 Closes apache#14686 Closes apache#15594 Closes apache#15652 Closes apache#15850 Closes apache#15914 Closes apache#15918 Closes apache#16285 Closes apache#16389 Closes apache#16652 Closes apache#16743 Closes apache#16893 Closes apache#16975 Closes apache#17001 Closes apache#17088 Closes apache#17119 Closes apache#17272 Closes apache#17971 Added: Closes apache#17778 Closes apache#17303 Closes apache#17872 ## How was this patch tested? N/A Author: hyukjinkwon <[email protected]> Closes apache#18017 from HyukjinKwon/close-inactive-prs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contribution is my original work and I license the work to the project under the project's open source license.
What changes were proposed in this pull request?
OneVsRestModel applies labelMetadata to the output column, but the metadata could contain the wrong name. The attribute name was modified to match predictionCol.
How was this patch tested?
Manual Tests